Hi Davide Andreoli, Thanks for the good feedback :) Niraj, can you make a patch according to Davide's comment? All looks good.
But for #3, the captain will make something good in the dark or I will do that if I find time. Thanks. Daniel Juyung Seo (SeoZ) On Tue, Sep 17, 2013 at 4:08 AM, Davide Andreoli <d...@gurumeditation.it>wrote: > 2013/9/16 Davide Andreoli <d...@gurumeditation.it> > > > > > > > > > 2013/9/10 Niraj Kumar - Enlightenment Git <no-re...@enlightenment.org> > > > >> seoz pushed a commit to branch master. > >> > >> commit 8bebdc139801cc8933f6af907e4b84cf539b1106 > >> Author: Niraj Kumar <jiraj...@samsung.com> > >> Date: Tue Sep 10 15:47:13 2013 +0900 > >> > >> progressbar: Support second progress. > >> > >> This can be used by video/audio streaming such as youtube. > >> > > > > > > > > Really usefull feature, thanks for the addition. I just make this work in > > the python bindings. > > But I have some comments: > > > > 1. no vertical theme provided > > 2. no indicator label supported > > 3. the theme is really bad-looking (I'm hoping the captain will make > > something good in the dark theme) > > 4. the part names are a bit inconsistent: > > "elm.cur.progressbar1" is the "main" indicator bar, while > > "elm.cur.progressbar" is the "secondary" indicator bar > > > > > > IMO 1 and 2 are quite essential features. And about the part names I > think > > they should be (at least) swapped > > > > oh, I forgot the fifth point: > 5. why the hell the style is called "recording" ?? shouldn't be better > something like: "double" or "multiple" ?? > > > > > > > thoughts? > > > > -- > > > >> > >> > >> > ------------------------------------------------------------------------------ > >> How ServiceNow helps IT people transform IT departments: > >> 1. Consolidate legacy IT systems to a single system of record for IT > >> 2. Standardize and globalize service processes across IT > >> 3. Implement zero-touch automation to replace manual, redundant tasks > >> > >> > http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk > >> > > > > > > ------------------------------------------------------------------------------ > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, > SharePoint > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack > includes > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. > http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
