Well I am not against but I am worried about some issue related to this
implementation.
To support this correctly, we should maintain all the strings and part
names inside each widget. Actually this is what I asked to Michael Bouchaud.
But this is error-prone.
And actually many of widgets do not support this kind of item text set.
Many widgets do not even have item text set hook and even they have item
text set hook, some of them only accept "default" part.
I hope this will get better but we need to fix many parts.
Thanks.
Daniel Juyung Seo (SeoZ)
On Tue, Sep 17, 2013 at 1:39 PM, ChunEon Park <her...@naver.com> wrote:
> conceptually this is acceptable to me, already all widgets support this
> kind of customized text set.
>
> ------------------------------------
> -Regards, Hermet-
>
> -----Original Message-----
> From: "Michaël Bouchaud"<y...@efl.so>
> To: "Enlightenment developer list"<
> enlightenment-devel@lists.sourceforge.net>;
> Cc: <g...@lists.enlightenment.org>;
> Sent: 2013-09-16 (월) 22:14:56
> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary:
> allow custom text part on item list
>
> Of course, I can check this. I will try to do it before tonight and fix it.
>
>
> 2013/9/16 Daniel Juyung Seo <seojuyung2>@gmail.com>
>
> > Hello Michael Bouchaud,
> > does this really work?
> >
> > It's likely this works only in a very rare cases.
> > It will be broken in many cases, especially theme change will break this.
> > The label inside the list is managed by elm_list and it'll set the label
> > when the theme is changed.
> > And so on...
> >
> > Can you check this?
> >
> > Daniel Juyung Seo (SeoZ)
> >
> >
> > On Mon, Sep 16, 2013 at 7:20 PM, Michaël Bouchaud - Enlightenment Git <
> > no-re...@enlightenment.org> wrote:
> >
> > > yoz pushed a commit to branch master.
> > >
> > > commit 5414fdba3c874451b43e0994df897bb3705b1f2d
> > > Author: Michaël Bouchaud (yoz) <yoz>@efl.so>
> > > Date: Mon Sep 16 12:18:24 2013 +0200
> > >
> > > elementary: allow custom text part on item list
> > > ---
> > > src/lib/elm_list.c 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/src/lib/elm_list.c b/src/lib/elm_list.c
> > > index e193fdf..72d3e9f 100644
> > > --- a/src/lib/elm_list.c
> > > +++ b/src/lib/elm_list.c
> > > @@ -1405,7 +1405,11 @@ _item_text_set_hook(Elm_Object_Item *it,
> > > {
> > > Elm_List_Item *list_it = (Elm_List_Item *)it;
> > >
> > > - if (part && strcmp(part, "default")) return;
> > > + if (part && strcmp(part, "default"))
> > > + {
> > > + edje_object_part_text_escaped_set(VIEW(list_it), part, text);
> > > + return;
> > > + }
> > > if (!eina_stringshare_replace(&list_it->label, text)) return;
> > > if (VIEW(list_it))
> > > edje_object_part_text_escaped_set(VIEW(list_it), "elm.text",
> text);
> > >
> > > --
> > >
> > >
> > >
> >
> >
> ------------------------------------------------------------------------------
> > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
> > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8,
> > SharePoint
> > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack
> > includes
> > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
>
> --
> Michaël Bouchaud (yoz) <yoz>@efl.so>
>
> ------------------------------------------------------------------------------
> LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
> 1,500+ hours of tutorials including VisualStudio 2012, Windows 8,
> SharePoint
> 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack
> includes
> Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
> http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
> ------------------------------------------------------------------------------
> LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
> 1,500+ hours of tutorials including VisualStudio 2012, Windows 8,
> SharePoint
> 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack
> includes
> Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
> http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
