ah... this looks wrong to me.

if you delete the animator, then item  on pushing will be corrupted.

I revised the patch.

commit 1eb541ffe663347c247168eca067602a3f928ef4 
 
------------------------------------
-Regards, Hermet- 

-----Original Message-----
From: "Jaehyun Cho"<[email protected]> 
To: <[email protected]>; 
Cc: 
Sent: 2013-09-18 (수) 02:21:45
Subject: [EGIT] [core/elementary] master 01/01: [naviframe] Enable item pop 
during item push.

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=db6be5cba076ff66dc58491972b30506d98f4df3

commit db6be5cba076ff66dc58491972b30506d98f4df3
Author: Jaehyun Cho <jae_hyun.cho>@samsung.com>
Date:   Wed Sep 18 02:20:33 2013 +0900

    [naviframe] Enable item pop during item push.
    
    Enable item pop during item is pushing (during item push transition).
---
 src/lib/elc_naviframe.c  5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c
index 5347fe8..95aab57 100644
--- a/src/lib/elc_naviframe.c
+++ b/src/lib/elc_naviframe.c
@@ -1663,10 +1663,11 @@ _item_pop(Eo *obj, void *_pd, va_list *list)
    it = (Elm_Naviframe_Item *)elm_naviframe_top_item_get(obj);
    if (!it) return;
 
-   if (it->animator  it->popping) return;
-
+   if (it->popping) return;
    it->popping = EINA_TRUE;
 
+   ELM_SAFE_FREE(it->animator, ecore_animator_del);
+
    if (it->pop_cb)
      {
         if (!it->pop_cb(it->pop_data, (Elm_Object_Item *)it))

-- 


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to