tasn pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=42d29b55e596313562c31cfe7d15402b51aa0d0c
commit 42d29b55e596313562c31cfe7d15402b51aa0d0c Author: Tom Hacohen <[email protected]> Date: Mon Sep 30 14:10:21 2013 +0100 Eo: don't va_start without a matching va_end. Fixes coverity CID1099707. --- src/lib/eo/eo.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c index 2abff09..b838bb3 100644 --- a/src/lib/eo/eo.c +++ b/src/lib/eo/eo.c @@ -427,22 +427,26 @@ eo_do_super_internal(const char *file, int line, const Eo *obj_id, const Eo_Clas EO_CLASS_POINTER_RETURN_VAL(cur_klass_id, cur_klass, EINA_FALSE); - va_start(p_list, op); if (_eo_is_a_class(obj_id)) { EO_CLASS_POINTER_RETURN_VAL(obj_id, klass, EINA_FALSE); + + va_start(p_list, op); nklass = _eo_kls_itr_next(klass, cur_klass, op); op_ret = _eo_op_internal(file, line, (Eo_Base *) klass, nklass, EO_OP_TYPE_CLASS, op, &p_list); + va_end(p_list); } else { EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, EINA_FALSE); + + va_start(p_list, op); nklass = _eo_kls_itr_next(obj->klass, cur_klass, op); op_ret = _eo_op_internal(file, line, (Eo_Base *) obj, nklass, EO_OP_TYPE_REGULAR, op, &p_list); if (obj->do_error) ret = EINA_FALSE; + va_end(p_list); } - va_end(p_list); if (!op_ret) _EO_OP_ERR_NO_OP_PRINT(file, line, op, nklass); --
