jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=f5fee255de5a2e9f33c2d2f5b87b9ba02fd65922

commit f5fee255de5a2e9f33c2d2f5b87b9ba02fd65922
Author: Jean-Philippe Andre <[email protected]>
Date:   Fri Aug 2 15:16:24 2013 +0900

    evas/cserve2: Fix race condition on font load / socket fail
    
    If the client exits while the server is loading fonts,
    the font entry objects are accessed after being freed.
    
    Note: This is not a proper fix. The race condition should still
    be fixed, but delaying client deletion a bit might help for a while...
---
 src/bin/evas/evas_cserve2_messages.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/bin/evas/evas_cserve2_messages.c 
b/src/bin/evas/evas_cserve2_messages.c
index e5cb1b7..168bd72 100644
--- a/src/bin/evas/evas_cserve2_messages.c
+++ b/src/bin/evas/evas_cserve2_messages.c
@@ -172,9 +172,6 @@ cserve2_client_send(Client *client, const void *data, 
size_t size)
         // so we must close the connection to the client and remove
         // its references inside our cache.
         WRN("Error on socket with client %d: %s", client->id, strerror(errno));
-        if (client->msg.reading)
-          _client_msg_free(client);
-        cserve2_client_del(client);
         return sent;
      }
    if (sent < 0)

-- 


Reply via email to