cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=11bad338139ff2d229a145827b9fcff54a677ef1

commit 11bad338139ff2d229a145827b9fcff54a677ef1
Author: Cedric Bail <[email protected]>
Date:   Tue Nov 5 16:28:56 2013 +0900

    epp: avoid to rely on undefined behavior for fopen.
    
    In the case we didn't define the file to save to, fopen would have
    been called with a NULL parameter. The result of that call is not
    really defined and could have led to some crash at some point.
---
 src/bin/edje/epp/cpplib.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/bin/edje/epp/cpplib.c b/src/bin/edje/epp/cpplib.c
index af65241..4314b15 100644
--- a/src/bin/edje/epp/cpplib.c
+++ b/src/bin/edje/epp/cpplib.c
@@ -7448,8 +7448,9 @@ extern cpp_options         options;
 void
 using_file(const char *filename, const char type)
 {
-   FILE *f;
+   FILE *f = NULL;
 
+   if (!options.watchfile) return;
    f = fopen(options.watchfile, "a");
    if (!f) return;
    if (anotate)

-- 


Reply via email to