devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=164269a2dae3b15c37a319e43b5fc38d9bcd2038

commit 164269a2dae3b15c37a319e43b5fc38d9bcd2038
Author: Chris Michael <[email protected]>
Date:   Mon Nov 18 11:48:00 2013 +0000

    Malloc cannot accept a negative number so check 'num' parameter before
    calling malloc.
    
    Fixes Coverity CID1039352
    
    Signed-off-by: Chris Michael <[email protected]>
---
 src/lib/ecore_con/ecore_con.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c
index fece5f3..d28a845 100644
--- a/src/lib/ecore_con/ecore_con.c
+++ b/src/lib/ecore_con/ecore_con.c
@@ -1176,7 +1176,7 @@ ecore_con_event_client_data(Ecore_Con_Client *cl, 
unsigned char *buf, int num, E
    cl->host_server->event_count = 
eina_list_append(cl->host_server->event_count, e);
    _ecore_con_cl_timer_update(cl);
    e->client = cl;
-   if (duplicate)
+   if ((duplicate) && (num > 0))
      {
         e->data = malloc(num);
         if (!e->data)

-- 


Reply via email to