tasn pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=e31472e8c32e7f74b4d8f9946e48bb00ef08117f

commit e31472e8c32e7f74b4d8f9946e48bb00ef08117f
Author: Tom Hacohen <[email protected]>
Date:   Mon Nov 25 16:31:21 2013 +0000

    Entry: Fix scroller position to show cursor.
    
    Before this commit, this would not always be the case.
    I added a "scroll to cursor" for every change in entry size.
    
    This is a further fix to T169. It's not exactly what described there,
    but it's a similar issue I found while fixing it.
    
    Somehow of a stage 2 for commit 80844cbcd72d5c3c00104b8bf8f9c5e590bad2bc.
    This also adds changelog and news entries, as this issue is now fully fixed.
---
 ChangeLog         | 5 +++++
 NEWS              | 1 +
 src/bin/e_entry.c | 7 +++++++
 3 files changed, 13 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index f49d0c8..ce0aa19 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,9 @@
+2013-11-25 Tom Hacohen
+
+       * Entry: Fixed issues with entry not scrolling to cursor.
+
 2013-11-05 Tom Hacohen
+
        * wsod: Fixed gdb hangs when generating backtraces.
 
 2013-10-07 Mike Blumenkrantz
diff --git a/NEWS b/NEWS
index d06bd69..ad36bc9 100644
--- a/NEWS
+++ b/NEWS
@@ -235,3 +235,4 @@ Fixes:
     * fixed filemanager spring window closing when dragging from desktop
     * fixed catching XWindow closes during DND operations on those windows
     * wsod: Fixed gdb hangs when generating backtraces.
+    * Entry: Fixed issues with entry not scrolling to cursor.
diff --git a/src/bin/e_entry.c b/src/bin/e_entry.c
index 832b6d1..2e3f9fa 100644
--- a/src/bin/e_entry.c
+++ b/src/bin/e_entry.c
@@ -696,6 +696,13 @@ _entry_recalc_size(Evas_Object *object)
    evas_object_geometry_get(sd->entry_object, NULL, NULL, &pw, &ph);
    if ((w == pw) && (h == ph)) return;
    evas_object_resize(sd->entry_object, w, h);
+
+     {
+        Evas_Coord cx, cy, cw, ch;
+        edje_object_part_text_cursor_geometry_get(sd->entry_object,
+              ENTRY_PART_NAME, &cx, &cy, &cw, &ch);
+        e_scrollframe_child_region_show(sd->scroll_object, cx, cy, cw, ch);
+     }
 }
 
 static void

-- 


Reply via email to