Coverity checks if a function can return NULL, and if it does and the
user dereferences the result; error.
A quick googling says coverity also checks for dereference of *alloc
return without NULL check.
S.
On 12/10/2013 09:20 PM, Michael Blumenkrantz wrote:
> right, but most analyzers I've seen only flag issues if there's a single
> instance of a null being checked in a function. usually they seem to assume
> that it can't be null otherwise
>
> On Tue, 10 Dec 2013 21:17:36 +0100
> Sebastian Dransfeld <s...@tango.flipp.net> wrote:
>
>> Hm, maybe. The problem here is that we return NULL from e_object_alloc
>> on alloc fail. I don't think coverity bothers if we check {m,c,re}alloc
>> return value.
>>
>> S.
>>
>> On 12/10/2013 09:13 PM, Michael Blumenkrantz wrote:
>>> no idea on that, but I think it will only flag issues on these types of
>>> things if there is a check for the object in the function somewhere...
>>>
>>> On Tue, 10 Dec 2013 21:11:16 +0100
>>> Sebastian Dransfeld <s...@tango.flipp.net> wrote:
>>>
>>>> Is it possible to mass ignore this in coverity? "malloc always succeeds
>>>> in this app".
>>>>
>>>> S.
>>>>
>>>> On 12/10/2013 09:04 PM, Michael Blumenkrantz wrote:
>>>>> I'm not actively removing it unless I'm rewriting entire chunks, but I'm
>>>>> not adding them.
>>>>>
>>>>> there's no point in alloc checking because it just causes the crash to
>>>>> occur in the return function since there's no error checking anywhere.
>>>>>
>>>>> On Tue, 10 Dec 2013 21:01:05 +0100
>>>>> Sebastian Dransfeld <s...@tango.flipp.net> wrote:
>>>>>
>>>>>> Is it?
>>>>>>
>>>>>> bd = E_OBJECT_ALLOC(E_Border, E_BORDER_TYPE, _e_border_free);
>>>>>> if (!bd) return NULL;
>>>>>>
>>>>>> But I can follow any guideline.
>>>>>>
>>>>>> S.
>>>>>>
>>>>>> On 12/10/2013 08:40 PM, Michael Blumenkrantz wrote:
>>>>>>> ughhhh can we not do this? there's no point in adding them, and I
>>>>>>> thought
>>>>>>> this was an established thing in e
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Dec 10, 2013 at 2:37 PM, Sebastian Dransfeld
>>>>>>> <s...@tango.flipp.net>wrote:
>>>>>>>
>>>>>>>> englebass pushed a commit to branch master.
>>>>>>>>
>>>>>>>>
>>>>>>>> http://git.enlightenment.org/core/enlightenment.git/commit/?id=ae8a067e6dd1d9e7035571dc7d260597505e776f
>>>>>>>>
>>>>>>>> commit ae8a067e6dd1d9e7035571dc7d260597505e776f
>>>>>>>> Author: Sebastian Dransfeld <s...@tango.flipp.net>
>>>>>>>> Date: Tue Dec 10 20:37:17 2013 +0100
>>>>>>>>
>>>>>>>> e: Check whether allocation succeeds
>>>>>>>>
>>>>>>>> CID 1039865
>>>>>>>> ---
>>>>>>>> src/bin/e_container.c | 1 +
>>>>>>>> 1 file changed, 1 insertion(+)
>>>>>>>>
>>>>>>>> diff --git a/src/bin/e_container.c b/src/bin/e_container.c
>>>>>>>> index 636fef7..fc354af 100644
>>>>>>>> --- a/src/bin/e_container.c
>>>>>>>> +++ b/src/bin/e_container.c
>>>>>>>> @@ -339,6 +339,7 @@ e_container_shape_add(E_Container *con)
>>>>>>>> E_OBJECT_TYPE_CHECK_RETURN(con, E_CONTAINER_TYPE, 0);
>>>>>>>>
>>>>>>>> es = E_OBJECT_ALLOC(E_Container_Shape, E_CONTAINER_SHAPE_TYPE,
>>>>>>>> _e_container_shape_free);
>>>>>>>> + if (!es) return NULL;
>>>>>>>> E_OBJECT_DEL_SET(es, _e_container_shape_del);
>>>>>>>> es->con = con;
>>>>>>>> con->shapes = eina_list_append(con->shapes, es);
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>
>> ------------------------------------------------------------------------------
>> Rapidly troubleshoot problems before they affect your business. Most IT
>> organizations don't have a clear picture of how application performance
>> affects their revenue. With AppDynamics, you get 100% visibility into your
>> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
>> Pro!
>> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
