On Wed, Dec 11, 2013 at 1:58 PM, Tom Hacohen <tom.haco...@samsung.com> wrote: > On 11/12/13 15:48, Gustavo Sverzut Barbieri wrote: >> On Wed, Dec 11, 2013 at 2:58 AM, Cedric BAIL <cedric.b...@free.fr> wrote: >>> cedric pushed a commit to branch master. >>> >>> http://git.enlightenment.org/core/efl.git/commit/?id=94b4e53b7f795a63ae4cfd5e01d2fa546582210b >>> >>> commit 94b4e53b7f795a63ae4cfd5e01d2fa546582210b >>> Author: Cedric BAIL <cedric.b...@samsung.com> >>> Date: Wed Dec 11 11:39:09 2013 +0900 >>> >>> autotools: make systemd dependency detection automatic. >>> --- >>> configure.ac | 18 +++++++++--------- >>> 1 file changed, 9 insertions(+), 9 deletions(-) >>> >>> diff --git a/configure.ac b/configure.ac >>> index 6409fb2..540bcb4 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -351,13 +351,6 @@ esac >>> AM_CONDITIONAL([HAVE_CRYPTO_GNUTLS], [test "${build_crypto}" = "gnutls"]) >>> AM_CONDITIONAL([HAVE_CRYPTO_OPENSSL], [test "${build_crypto}" = >>> "openssl"]) >>> >>> -# check for systemd library if requested >>> -if test "x{want_systemd}" = "xyes"; then >>> - PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon >= 192 >>> libsystemd-journal >= 192], >>> - [want_systemd="yes"], >>> - [want_systemd="no"]) >>> -fi >>> - >>> #### Checks for header files >>> >>> # Common Checks (keep names sorted for ease of use): >>> @@ -575,9 +568,16 @@ AC_ARG_ENABLE([systemd], >>> want_systemd="no" >>> fi >>> ], >>> - [want_systemd="no"]) >>> -AM_CONDITIONAL([WANT_SYSTEMD], [test "${want_systemd}" = "yes"]) >>> + [want_systemd="auto"]) >>> >>> +# check for systemd library if requested >>> +if test "x${want_systemd}" = "xyes" -o "x${want_systemd}" = "xauto"; then >>> + PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon >= 192 >>> libsystemd-journal >= 192], >>> + [want_systemd="yes"], >>> + [want_systemd="no"]) >>> +fi >>> + >>> +AM_CONDITIONAL([WANT_SYSTEMD], [test "${want_systemd}" = "yes"]) >> >> GOD I've been fighting this forever and you do this?! Come on. >> >> Either you disable or enable it by default and let it fail, people >> should specify and be clear of what they want (or can provide)... I've >> explained this thousand times already. >> >> Also, you SILENTLY IGNORE systemd not being present if user demanded >> it! This is horrible and breaks expected behavior of build packages. >> Since you wanted to do it automatic, which I CLEARLY REJECT, please >> make it fail if --enable-systemd and it wasn't found! >> >> Seriously, please consider reverting this patch unless you can justify >> why it is good. >> > > We've discussed this many times, I'm 100% with you. This patch should be > reverted ASAP. Auto detection is horrible, and it was agreed we won't be > doing this any more.
I did check and before this patch the only other auto-detection that we had were: - valgrind for debug or dev profiles, which is okay/valid (not release); - jp2k loader, which is not valid, must be enabled by default (or disabled if openjp2 is not common nowadays) -- Gustavo Sverzut Barbieri -------------------------------------- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
