it's about quality it was not error. i didn't fix any broken things. But tried to improve the interploation.
------------------------------------ -Regards, Hermet- -----Original Message----- From: "Tom Hacohen"<tom.haco...@samsung.com> To: <enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2014-01-02 (목) 23:33:04 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas/common - more elaborated compuatation in interpolation. On 02/01/14 14:27, Daniel Juyung Seo wrote: > On Thu, Jan 2, 2014 at 10:11 PM, Tom Hacohen <tom.hacohen>@samsung.com>wrote: > >> On 02/01/14 13:00, ChunEon Park wrote: >>> why it should be there be average? then? >>> what is it much different with you? >>> >>> the change was only 3 lines >>> >>>> - u = (u * p) / (x2 + 1); >>>> + u = ((u * p) / x2); >>> >>> and i mentioned, >>> "it should not +1 in the interpolation." >> >> OK. Re-read your initial commit message, and changing the summary line >> makes it good: >> > > Hi > > >> >> "evas/common: Fixed computation in interpolation. >> >> > I am not sure if I understood correctly but if this commit message is what > you consider "good", hermet's commit message also looks ok. > Is there any limited set of words for the commit summary line like " > 'fixed' is allowed but not 'elaborated' " > Thanks. There are no "keywords". "Elaborated" means "improved"/"added details". When I read the commit message with that, it looks as if he described what he was doing. Now that I know that there was a problem with the formula (as indicated by "fixed"), the second part makes sense. -- Tom. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
