Hello.

On Mon, 2014-01-06 at 23:19, Daniel Juyung Seo wrote:
> On Mon, Jan 6, 2014 at 6:21 PM, David Seikel <onef...@gmail.com> wrote:
> 
> > On Mon, 6 Jan 2014 09:31:59 +0100 Stefan Schmidt
> > <ste...@datenfreihafen.org> wrote:
> >
> > > clang scan-build:
> > > o EFL scan-build reports 484 (483) issues.
> > >
> > https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfu
> > > lBuild/artifact/scan-build/build/
> > > o Elementary scan-build reports 121 (119)
> >
> > Elementary reports 121 of what?  Hard to tell if this is good or bad.
> > I would guess it's "issues" like the EFL version just above it.  Should
> > state that.
> >
> >
> It looks like there are many false alarms but can't mark it as false alarm
> like coverity.
> For example, in internal function, we used ELM_WIDGET_DATA_GET(obj, sd) and
> clang reported "dereference of null pointer" on sd->resize_obj.
> But sd should not be null inside internal functions and checking null will
> hide the root problem.
> Is there a way to fix the clang build or we should just follow the reports?

The scan build from clang does only generate static html pages. There
is no web ui or similar to mark issues as flase positive. Thats quite
a downside and you would have to ignore them every time.

I'm not a fan either of cluttering our code just to make some stupid
tool happy. There are two options out of this a) find out if
scan-build has some configuration to ignore specific problems or b)
improve scan build to behave better.

IIRC Daniel Willmann was looking into a) at some point. If anyone else
comes up with some "surpression" file to ignore these I would be more
than happy to integrate it in our build.

> Anyhow, I found some useful reports from clang.
> Thanks clang!

Good. Glad there it also shows some real bugs and you are even able to
find them in the noise. :)

regards
Stefan Schmidt

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to