tasn pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=d095f784474c410970c7e57195bfed2e3a1d09e2
commit d095f784474c410970c7e57195bfed2e3a1d09e2 Author: Tom Hacohen <[email protected]> Date: Mon Jan 6 14:58:18 2014 +0000 Widget: Don't check if it's the correct class everywhere. ELM_WIDGET_DATA_GET was checking it was the correct class. This is stupid and wrong (and makes tools rightfully complain) because these functions are implementations of that class anyway, so that would never be false. Functions that outside facing (that is, not called from eo_do) should use API_ENTRY. --- src/lib/elm_widget.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c index 543b8f4..8e2d034 100644 --- a/src/lib/elm_widget.c +++ b/src/lib/elm_widget.c @@ -16,8 +16,7 @@ EAPI Eo_Op ELM_WIDGET_BASE_ID = EO_NOOP; #define MY_CLASS_NAME_LEGACY "elm_widget" #define ELM_WIDGET_DATA_GET(o, wd) \ - Elm_Widget_Smart_Data *wd = NULL; \ - if (eo_isa(o, MY_CLASS)) wd = eo_data_scope_get(o, MY_CLASS) + Elm_Widget_Smart_Data *wd = eo_data_scope_get(o, MY_CLASS) #define API_ENTRY \ ELM_WIDGET_DATA_GET(obj, sd); \ --
