On Mon, 6 Jan 2014 15:47:07 -0200 Gustavo Sverzut Barbieri <barbi...@gmail.com> said:
> On Mon, Jan 6, 2014 at 1:16 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > > raster pushed a commit to branch master. > > > > http://git.enlightenment.org/core/efl.git/commit/?id=6f685d760851e1ccf33017b2a749008475e2ac7c > > > > commit 6f685d760851e1ccf33017b2a749008475e2ac7c > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > Date: Mon Jan 6 12:16:36 2014 +0900 > > > > fixme notes - fixme: many instances of module loading that bloat our mem > > --- > > src/lib/ecore/ecore.c | 5 +++++ > > src/lib/ecore_imf/ecore_imf_module.c | 3 +++ > > src/lib/eeze/eeze_sensor.c | 3 +++ > > src/lib/eina/eina_mempool.c | 3 +++ > > src/lib/ethumb/ethumb.c | 5 +++++ > > 5 files changed, 19 insertions(+) > > > > diff --git a/src/lib/ecore/ecore.c b/src/lib/ecore/ecore.c > > index 5870206..3477aca 100644 > > --- a/src/lib/ecore/ecore.c > > +++ b/src/lib/ecore/ecore.c > > @@ -183,6 +183,11 @@ ecore_system_modules_load(void) > > eina_prefix_lib_get(_ecore_pfx)); > > module_list = eina_module_arch_list_get(module_list, buf, MODULE_ARCH); > > > > + // XXX: MODFIX: do not list ALL modules and load them ALL! this is > > + // just polluting memory pages and I/O with modules and code that > > + // is then never used. detetc the module we need to use them use > > + // that. if anything load each module, have it do a detect and if > > + // it fails UNLOAD and try the next one. > > eina_module_list_load(module_list); > > } > > Are you sure what you're talking about? we always use all installed > system modules, they are in their own directory for that reason. you use tizen, upower AND systemd at the same time? both systemd and tizen handle ECORE_EVENT_LOCALE_CHANGED events. both upower and tizen handle ecore_power_state_set(). even if there is no systemd daemon (and dbus service) or upower service... or vconf database is missing (libs there, data is not), we load ALL modules and init ALL modules and we KEEP all modules we loaded, even if their own inits failed. so we have conflicting domain control above since multiple modules are installed (no decision on which one wins or loses), and failed inits keep the module loaded though - forever. :) > other comments in this commit may be correct, I'm not sure but likely > we don't want to read imf modules we're not using, not sure about eeze > sensors... -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
