looks okay to me, do you have commit access? Otherwise I can commit for you
On Sun, Jan 19, 2014 at 7:26 AM, Albin Tonnerre <[email protected]> wrote: > Hi, > > I just tried building EFL 1.8 on my Chromebook at it appears that even > though the CPU supports NEON, the code snippet doing NEON detection in > configure.ac fails (using Debian Unstable, GCC 4.8.2): > > configure:23270: checking whether to use NEON instructions > configure:23283: gcc -std=gnu99 -c -g -O2 -fstack-protector > --param=ssp-buffer-size=4 -Wformat -Werror=format-security > -fvisibility=hidden -D_FORTIFY_SOURCE=2 conftest.c >&5 > In file included from conftest.c:59:0: > /usr/lib/gcc/arm-linux-gnueabihf/4.8/include/arm_neon.h:32:2: error: > #error You must enable NEON instructions (e.g. -mfloat-abi=softfp > -mfpu=neon) to use arm_neon.h > #error You must enable NEON instructions (e.g. -mfloat-abi=softfp > -mfpu=neon) to use arm_neon.h > ^ > > The following patch fixes the issue for me. Does that look OK to you? > In that case, can it be cherry-picked in the efl-1.8 branch? > > --- configure.ac 2014-01-07 15:25:10.000000000 +0100 > +++ configure.ac 2014-01-19 10:12:04.658764527 +0100 > @@ -516,6 +516,8 @@ > arm*) > build_cpu_neon="yes" > AC_MSG_CHECKING([whether to use NEON instructions]) > + CFLAGS_save="${CFLAGS}" > + CFLAGS="${CFLAGS} -mfpu=neon" > AC_TRY_COMPILE([#include <arm_neon.h>], > [asm volatile ("vqadd.u8 d0, d1, d0\n")], > [ > @@ -527,6 +529,7 @@ > AC_MSG_RESULT([no]) > build_cpu_neon="no" > ]) > + CFLAGS="${CFLAGS_save}" > ;; > esac > > > Thanks, > -- > Albin > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri -------------------------------------- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
