jihoon pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2c0c2b0fed6bc5d696b3e85d2da0bd943edac68e

commit 2c0c2b0fed6bc5d696b3e85d2da0bd943edac68e
Author: Jihoon Kim <[email protected]>
Date:   Wed Jan 22 09:46:24 2014 +0900

    ximimmodule: fix dereference after null check
    
    CID 1162749:  Dereference after null check  (FORWARD_NULL)
    /src/modules/ecore_imf/xim/ecore_imf_xim.c: 1027 in 
_ecore_imf_xim_preedit_draw_call()
---
 src/modules/ecore_imf/xim/ecore_imf_xim.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/modules/ecore_imf/xim/ecore_imf_xim.c 
b/src/modules/ecore_imf/xim/ecore_imf_xim.c
index 5598cac..66a355f 100644
--- a/src/modules/ecore_imf/xim/ecore_imf_xim.c
+++ b/src/modules/ecore_imf/xim/ecore_imf_xim.c
@@ -1024,7 +1024,10 @@ done:
              imf_context_data->feedbacks = 
calloc(imf_context_data->preedit_length, sizeof(XIMFeedback));
 
              for (i = 0; i < imf_context_data->preedit_length; i++)
-               imf_context_data->feedbacks[i] = t->feedback[i];
+               {
+                  if (t)
+                    imf_context_data->feedbacks[i] = t->feedback[i];
+               }
           }
 
         ecore_imf_context_preedit_changed_event_add(ctx);

-- 


Reply via email to