On Wed, Feb 5, 2014 at 8:28 PM, ChunEon Park <[email protected]> wrote:
> hermet pushed a commit to branch master.
>
> http://git.enlightenment.org/tools/enventor.git/commit/?id=0e7f161e9d29d8e6bac5e63c1e6f54d390e5a10a
>
> commit 0e7f161e9d29d8e6bac5e63c1e6f54d390e5a10a
> Author: ChunEon Park <[email protected]>
> Date: Wed Feb 5 20:27:03 2014 +0900
>
> removed void delcaration as the parameter.
>
> It doesn't mean that i don't agree on this.
> But for code consistency i removed.
You know that the prototype of those function are now completely
different ? You can now put as many and random parameter and the
compiler will be happy. It is really a bad practice. Better use void
every where, much less risk of bug.
> ---
> src/bin/main.c | 6 +++---
> src/bin/panes.c | 4 ++--
> src/include/statusbar.h | 8 ++++----
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/src/bin/main.c b/src/bin/main.c
> index 5c38ed6..feb34e8 100644
> --- a/src/bin/main.c
> +++ b/src/bin/main.c
> @@ -93,7 +93,7 @@ part_highlight_toggle(app_data *ad, Eina_Bool msg)
> }
>
> static void
> -auto_indentation_toggle(void)
> +auto_indentation_toggle()
> {
> Eina_Bool toggle = !config_auto_indent_get();
> if (toggle) stats_info_msg_update("Auto Indentation Enabled.");
> @@ -359,7 +359,7 @@ edc_edit_set(app_data *ad)
> }
>
> static void
> -statusbar_set(void)
> +statusbar_set()
> {
> Evas_Object *obj = stats_init(base_layout_get());
> elm_object_part_content_set(base_layout_get(), "elm.swallow.statusbar",
> @@ -505,7 +505,7 @@ elm_setup()
> }
>
> static void
> -edj_mgr_set(void)
> +edj_mgr_set()
> {
> edj_mgr_init(base_layout_get());
> base_left_view_set(edj_mgr_obj_get());
> diff --git a/src/bin/panes.c b/src/bin/panes.c
> index 57da902..da653dc 100644
> --- a/src/bin/panes.c
> +++ b/src/bin/panes.c
> @@ -146,14 +146,14 @@ right_clicked_cb(void *data, Evas_Object *obj, void
> *event_info EINA_UNUSED)
> }
>
> void
> -panes_full_view_right(void)
> +panes_full_view_right()
> {
> panes_data *pd = g_pd;
> right_clicked_cb(pd, pd->right_arrow, NULL);
> }
>
> void
> -panes_full_view_left(void)
> +panes_full_view_left()
> {
> panes_data *pd = g_pd;
> left_clicked_cb(pd, pd->left_arrow, NULL);
> diff --git a/src/include/statusbar.h b/src/include/statusbar.h
> index cf298bf..56f2ff8 100644
> --- a/src/include/statusbar.h
> +++ b/src/include/statusbar.h
> @@ -1,9 +1,9 @@
> Evas_Object *stats_init(Evas_Object *parent);
> -void stats_term(void);
> -void stats_view_size_update(void);
> +void stats_term();
> +void stats_view_size_update();
> void stats_cursor_pos_update(Evas_Coord x, Evas_Coord y, float rel_x, float
> rel_y);
> void stats_info_msg_update(const char *msg);
> void stats_line_num_update(int cur_line, int max_line);
> -Evas_Object *stats_obj_get(void);
> +Evas_Object *stats_obj_get();
> void stats_edc_group_set(const char *group_name);
> -Eina_Stringshare *stats_group_name_get(void);
> +Eina_Stringshare *stats_group_name_get();
>
> --
>
>
>
--
Cedric BAIL
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
