On Sun, 02 Feb 2014 12:17:04 -0500 Chris Seekamp <[email protected]> wrote:
> I have never submitted a potential code change for enlightenment before > so I apologize if I didn't do it properly. I tried to follow the > instructions for using git, arc, etc. I have never done this before > although I have written code for quite a few years. > > Even though I guess most of the emphasis now is e18, the revision is > against e17 (0.17.6) since that is what Bodhi still uses. I tried to > checkout the last e17 revision and make my change against that. The > change is simply to honor the udisks presentation hide bit and, if set, > ignore the partition which has it set. I tried to use phab to provide > the fix (all 2 lines of code plus comment of it) for review. I have no > idea who to put as reviewers. I don't know if I should have just > generated the diff and included it here, but it seems like the > documentation said to use phab. > > The proposed revision is at: https://phab.enlightenment.org/D505 > > I tried to follow the style and pattern of the existing code. I have > tested this on my own computer. Basically, you add rules to a rules file > under /etc/udev/rules.d with something like: > ENV{ID_FS_TYPE}=="vfat", ENV{ID_FS_LABEL}=="EFI-SYSTEM", > ENV{UDISKS_PRESENTATION_HIDE}="1" > > I would like to see this change added to both e17 and e18. It is > actually quite common to want to hide certain partitions, especially > when disk are multi-boot (which is the case I am dealing with) and when > there are system recovery partitions. > > Just an additional FYI. If when e goes to udisks2, the flag bit > indicating hide is different. I think is is UDISKS_IGNORE. That is > something to keep in mind for the future > -- Chris Seekamp [email protected] (sent using Icedove on my Samsung > Chromebook running Bodhi Linux) > in ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
