On Mon, 10 Feb 2014 18:04:50 +0100 Albin Tonnerre <[email protected]> said:
> On Mon, Feb 10, 2014 at 6:00 PM, Gustavo Sverzut Barbieri > <[email protected]> wrote: > > Hi Raster, > > > > This was added as Albin (ARM developer) requested, could you both > > check if it should stay or not? > > I'm unsure why that breaks build on earlier architectures, but > removing -mfpu=neon doesn't make the check any more correct: since > #include <arm_neon.h> will error out if you don't compile with the > flag, the net effect is that it's now disabled for everyone... > > What was the issue exactly? the check temporarily adds -mfpu-neon to then #include arm_neon.h + arm asm check as the next check and then enables neon builds if this works... then restores CFLAGS. so it turns neon on regardless if -mfpu-neon is on in my CFLAGS. if neon compiling requires -mfpu=neon (in the past it most certainly has with gcc), then this breaks unless my CFLAGS also contain or enable neon in some way. -mfpu=neon is not added manually to any Makefile.am to be attached to specific files either, so neon support compilation is enabled regardless if the relevant compiler options are on or not during compilation of that neon code. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
