sachiel pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=b317bedf5ab0398c8fb176293d315b905534f695

commit b317bedf5ab0398c8fb176293d315b905534f695
Author: Mike Blumenkrantz <[email protected]>
Date:   Mon Feb 17 13:47:52 2014 -0500

    remove comp object dirty flag
    
    this logic was useful for another issue which has since been fixed. it 
currently only serves the purpose of triggering a race condition crash which I 
do not enjoy.
---
 src/bin/e_comp_object.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/bin/e_comp_object.c b/src/bin/e_comp_object.c
index 5728ebe..75e87a6 100644
--- a/src/bin/e_comp_object.c
+++ b/src/bin/e_comp_object.c
@@ -91,7 +91,6 @@ typedef struct _E_Comp_Object
    Eina_Bool            zoomap_disabled : 1; //whether zoomap is usable
    Eina_Bool            updates_exist : 1;
    Eina_Bool            updates_full : 1; // entire object will be updated
-   Eina_Bool            dirty : 1; //object is dirty but not visible
 
    Eina_Bool            force_move : 1;
 } E_Comp_Object;
@@ -1882,8 +1881,6 @@ _e_comp_smart_show(Evas_Object *obj)
      }
    if (!cw->animating)
      e_comp_object_effect_set(obj, NULL);
-   if (cw->dirty)
-     e_comp_object_render_update_add(obj);
 }
 
 static void
@@ -3059,14 +3056,7 @@ e_comp_object_dirty(Evas_Object *obj)
    Eina_Bool dirty;
 
    API_ENTRY;
-   cw->dirty = 0;
    evas_object_geometry_get(cw->obj, NULL, NULL, &ow, &oh);
-   if ((!ow) && (!oh))
-     {
-        RENDER_DEBUG("DIRTY REJECTED(%p)", cw->ec);
-        cw->dirty = !cw->visible;
-        return; //get it on the next resize/show
-     }
    dirty = e_pixmap_size_get(cw->ec->pixmap, &w, &h);
    if (!dirty) w = h = 1;
    evas_object_image_pixels_dirty_set(cw->obj, dirty);

-- 


Reply via email to