On Tue, 11 Feb 2014 15:57:53 +0100 Bertrand Jacquin <be...@meleeweb.net> said:

> Raster,
> 
> Here is two patches:
> 
>  - 5e2de5352-E-public-wiki-now.patch
>    The modification you applied on E phab installation since
>    commit 5e2de5352255ff1ff95ffb73ec9c11ac4e62c5cf (Mon Nov 4
> 08:54:00 2013 HEAD)
> 
>  - a3acf5fc4-E-public-wiki-now.patch
>    Previous patch rebase on
>    commit a3acf5fc4b947a4d742d158383e348b4856f98eb (Mon Feb 10
> 16:13:56 2014 HEAD)
> 
> Note that your policies changes are partly applied in current HEAD since
> 591df78361a7 on file src/applications/files/storage/PhabricatorFile.php.
> 
> Please take me inform if you inappropriate things.

thanks man! thats what i wanted. cool! awesome. :)

> Bertrand
> 
> D'ar meurzh 11 a viz C'hwevrer 2014 e 11 eur 11, « Bertrand Jacquin » he deus
> skrivet :
> > D'ar meurzh 11 a viz C'hwevrer 2014 e 00 eur 26, « Carsten Haitzler » he
> > deus skrivet :
> > > On Mon, 10 Feb 2014 22:05:54 +0100 Bertrand Jacquin <be...@meleeweb.net>
> > > said:
> > > 
> > > > Hi raster,
> > > > 
> > > > Patches added to phab tree are present here :
> > > > http://git.meleeweb.net/distros/gentoo/portage.git/tree/www-apps/phabricator/files
> > > > and more precisely this one
> > > > http://git.meleeweb.net/distros/gentoo/portage.git/tree/www-apps/phabricator/files/0001-Make-wiki-visible-to-all.patch
> > > > 
> > > > All other have been handled upstream.
> > > > 
> > > > Please send me the patch if you need add some other to be able to get
> > > > upgrade done more easily and to keep track of such modifications.
> > > > 
> > > > Thanks for this
> > > 
> > > that patch above basically didn't work (that patch you refer to). because
> > > phab added a whole policy system and the wiki doesn't implement specific
> > > policies. i spent a lot of time learning this by poking at the code and
> > > adding debugging in to find how it was working. the wiki simply was not
> > > public at all until i fixed it yesterday. it is now.
> > 
> > Thanks for this.
> > 
> > > the problem is that i spent hours hacking files. i can't give you a patch
> > > because i don't have an original to compare it to. i modified maybe 30
> > > files or so along the way to figuring this out. to make this work i've
> > > got maybe 10 files changed. the installation is just a regular tree of
> > > files, i can't to "git diff" to get something. i don't have an original
> > > to compare against. where is the original phab tree BEFORE it was
> > > installed onto the server? that's what i'm asking. if you diff -R against
> > > that you'll get the current mods/patch set. :)
> > 
> > Ok, I didn't get that it that you changed files in place. Git tree for
> > phabricator was 5e2de5352255ff1ff95ffb73ec9c11ac4e62c5cf
> > 
> >  $ bzegrep 'declare .*
> > EGIT_VERSION=' /var/db/pkg/www-apps/phabricator-9999/environment.bz2
> > 
> > Installation is not handled via git directly but via portage to force us
> > keep track of such modifications and to not lost them (another time), it
> > maybe make things strange for you but really help when more than one person
> > touch them.
> > 
> > I will do a patch from your work and see if it still apply nice on more
> > recent releases.
> > 
> > Thanks for all this.
> > 
> > > > D'ar lun 10 a viz C'hwevrer 2014 e 11 eur 32, « Carsten Haitzler » he
> > > > deus skrivet :
> > > > > after many hours of futzing about in phab.. i've gotten itback to
> > > > > where it once was... with a publicly readable wiki! yay! problem is -
> > > > > not really possible to track changes due to the install not being a
> > > > > git tree.
> > > > > 
> > > > > beber - if you have the original git tree - compare (diff -r) the
> > > > > tree and extract the changes. i can tell you the files with ~ at the
> > > > > end i modified. :) but i modified them tonnes of times. i modified a
> > > > > tonne of other files along the way just to find out how phab
> > > > > worked... so it wasnt sane to make a backup of every single file
> > > > > before i modify.
> > > > > 
> > > > > -- 
> > > > > ------------- Codito, ergo sum - "I code, therefore I am"
> > > > > -------------- The Rasterman (Carsten Haitzler)
> > > > > ras...@rasterman.com
> > > > > 
> > > > 
> > > > -- 
> > > > Beber
> > > > 
> > > 
> > > 
> > > -- 
> > > ------------- Codito, ergo sum - "I code, therefore I am" --------------
> > > The Rasterman (Carsten Haitzler)    ras...@rasterman.com
> > > 
> > 
> > -- 
> > Bertrand Jacquin
> > Ingénieur technique
> > Tel: +33 1 30 67 60 65
> > GSM: +33 6 71 01 70 30
> > http://pom-monitoring.com
> > *POM Monitoring*, Pilotage de la performance du Systeme d'Information
> 
> -- 
> Bertrand Jacquin
> Ingénieur technique
> Tel: +33 1 30 67 60 65
> GSM: +33 6 71 01 70 30
> http://pom-monitoring.com
> *POM Monitoring*, Pilotage de la performance du Systeme d'Information


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to