Hello. On Fri, 2014-02-21 at 10:54, Cedric BAIL wrote: > On Fri, Feb 21, 2014 at 6:45 AM, davemds <d...@gurumeditation.it> wrote: > > davemds pushed a commit to branch master. > > > > http://git.enlightenment.org/core/emotion_generic_players.git/commit/?id=bcdffa9a7066c16f14b7e86d69f19122687bd95e > > > > commit bcdffa9a7066c16f14b7e86d69f19122687bd95e > > Author: davemds <d...@gurumeditation.it> > > Date: Thu Feb 20 22:45:16 2014 +0100 > > > > Emotion VLC: remove quite all the old hacks. > > > > This commit remove all the hacks that was there on the loading stage. > > Instead of using the tmp format callback system now simply connect to > > the MediaPlayerPlaying event on first startup and pause the video as > > soon as it start. > > > > No more need for the tmp buffer allocation and the delayed stop using > > idler. > > > > All this fix the first outstanding bug: audio was audible on start > > (before the real > > play command from emotion) > > That's a nice fix ! Just maybe a little bit big, but I have been > looking at other way to solve that problem and didn't found any.
I was also worried initially by how big it is but a big part is really the removal. In the end I'm convinced becasue you seem to have come to the same conclusion and are happy with the patch and that without it we would have a known bug for the release. Surely this could break something else but Dave is the one actively working with this code and did run into problems. Thanks for fixing this Dave! regards Stefan Schmidt ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
