On Fri, Feb 28, 2014 at 6:40 PM, Stefan Schmidt <[email protected]>wrote:
> Hello. > > On Fri, 2014-02-28 at 09:21, Tom Hacohen wrote: > > On 28/02/14 09:18, Daniel Juyung Seo wrote: > > > Daniel Juyung Seo (SeoZ) > > > On Feb 28, 2014 5:56 PM, "Tom Hacohen" <[email protected]> > wrote: > > >> > > >> On 28/02/14 08:48, Stefan Schmidt wrote: > > >>> Hello. > > >>> > > >>> On Thu, 2014-02-27 at 20:57, Gustavo Sverzut Barbieri wrote: > > >>>> barbieri pushed a commit to branch master. > > >>>> > > >>>> > > > > http://git.enlightenment.org/core/elementary.git/commit/?id=cfd4179ce7a052c685c1c03f9b98467456578dce > > >>>> > > >>>> commit cfd4179ce7a052c685c1c03f9b98467456578dce > > >>>> Author: Gustavo Sverzut Barbieri <[email protected]> > > >>>> Date: Fri Feb 28 01:46:13 2014 -0300 > > >>>> > > >>>> elm_list/focus: @bugfix crashes with empty lists and unfocused > > > elements. > > >>> > > >>> Its nice to see that the @bugfix (@fix might be easier) and @feature > > >>> tags are getting more use. > > >>> > > >>> Personally I would prefer if we could put them in the body of the > > >>> commit message. Like the phab ticket id or the Coverity ID. My reason > > >>> would be simply aesthetical as I looks ugly to have such tags in the > > >>> oftenm already cramped summary line. > > >>> > > >>> Putting them in the body makes them available for tools and sacripts > > >>> but does not waste space on the summary line or make them look ugly. > > >> > > >> Yep, and also wastes precious summary line space. > > >> > > > > > > Yes +1 and that is what we have agreed. > > > Btw how do you search commits which have that tag and get its summary? > > > > git log --grep="@feature" > > > > Also, it's a normal git log, so you can format it however you'd like, > > add time/author based filters, and etc. > > Hi > Daniel, the PRETTY FORMATS section it the git log man page will show > you all the fancy stuff you can do with git log. :) > > But grepping would only be one small benefit. The two main benefits > are: > > 1) With @fix you can identify commits that should also get backported > because they fix code that already existed in the last dev cycle and > not only recent code. > > 2) Based on the @fix and @feature tags we can filter commits into the > right categories when generating a NEWS file from the git log during > release preparations. This lowers the manual labor to do this kind of > release busywork. > > Thanks for the information but I was aware of the requirement already. But thanks for sharing that for others again :) Now it is getting clearer to others I think. Daniel Juyung Seo (SeoZ) > regards > Stefan Schmidt > > > ------------------------------------------------------------------------------ > Flow-based real-time traffic analytics software. Cisco certified tool. > Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer > Customize your own dashboards, set traffic alerts and generate reports. > Network behavioral analysis & security monitoring. All-in-one tool. > > http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
