Hello. On Mon, 2014-03-03 at 01:20, Stefan Schmidt wrote: > stefan pushed a commit to branch efl-1.8. > > http://git.enlightenment.org/core/efl.git/commit/?id=1b251dc707219edadf51e467fabac99fb5cae1a0 > > commit 1b251dc707219edadf51e467fabac99fb5cae1a0 > Author: Stefan Schmidt <[email protected]> > Date: Mon Mar 3 10:19:48 2014 +0100 > > Revert "evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE." > > This reverts commit eb022cba1d1df351d5f5043879eade5cee9d918c. > > This does not even compile. Blindly backported without any testing.
lib/evas/canvas/evas_object_main.c:656:46: error: 'l' undeclared (first use in this function) Its not acceptable to blindly cherry-pick commits form master and put them inot a stable branch without any testing. Gives me a grumpy start into the week. regards Stefan Schmidt > --- > src/lib/evas/canvas/evas_object_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/evas/canvas/evas_object_main.c > b/src/lib/evas/canvas/evas_object_main.c > index eed4429..0480098 100644 > --- a/src/lib/evas/canvas/evas_object_main.c > +++ b/src/lib/evas/canvas/evas_object_main.c > @@ -653,7 +653,7 @@ _destructor(Eo *eo_obj, void *_pd, va_list *list > EINA_UNUSED) > goto end; > } > evas_object_grabs_cleanup(eo_obj, obj); > - EINA_LIST_FOREACH_SAFE(obj->clip.clipees, l, l2, tmp) > + EINA_LIST_FREE(obj->clip.clipees, tmp) > evas_object_clip_unset(tmp->object); > while (obj->proxy->proxies) > evas_object_image_source_unset(obj->proxy->proxies->data); ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
