we already do this in elm_widget_item_del.
so you try to check NULL twice.

------------------------------------
-Regards, Hermet-

-----Original Message-----
From: "Daniel Juyung Seo"<[email protected]> 
To: <[email protected]>; 
Cc: 
Sent: 2014-03-03 (월) 18:19:39
Subject: [EGIT] [core/elementary] master 02/02: object_item: Check null in 
elm_object_item_del.

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=75980ef76101a0859f889e76b6e5d97d33972846

commit 75980ef76101a0859f889e76b6e5d97d33972846
Author: Daniel Juyung Seo <seojuyung2>@gmail.com>
Date:   Mon Mar 3 18:17:32 2014 +0900

    object_item: Check null in elm_object_item_del.
    
    As all EFL del/free APIs handle null as an exception,
       elm_object_item_del() should check null as well.
    @fix
---
 src/lib/elm_main.c  1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
index e49ade8..4268811 100644
--- a/src/lib/elm_main.c
+++ b/src/lib/elm_main.c
@@ -1837,6 +1837,7 @@ EAPI void elm_object_item_del_cb_set(Elm_Object_Item *it, 
Evas_Smart_Cb del_cb)
 
 EAPI void elm_object_item_del(Elm_Object_Item *it)
 {
+   if (!it) return;
    _elm_widget_item_del((Elm_Widget_Item *)it);
 }
 

-- 



------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to