Hello. On Tue, 2014-03-04 at 23:03, Simon Lees wrote: > raster pushed a commit to branch master. > > http://git.enlightenment.org/core/elementary.git/commit/?id=5003400f9ecb466aea951aa885f5729e101136df > > commit 5003400f9ecb466aea951aa885f5729e101136df > Author: Simon Lees <[email protected]> > Date: Wed Mar 5 15:55:26 2014 +0900 > > Enhancement: #define names for text colors > > Summary: > Previously text colors were specfied in the form color: XXX XXX XXX AAA > throughout all the edc files, eg color: 255 255 255 255 this made it > imposible to write a script to change text colors with sed as it changed many > other parts of the theme as well. > > Some colors had been defined in fonts.edc and in some places these were > used but not many. This change means that all non textblock font colors are > defined in fonts.edc and the defined names are used throughout the entire > code base. This means that sed only needs to be run on 1 file to change the > text color or it is easy to do manually > > textblock colors were not done for 2 reasons > 1. They hadn't been done in the past so there was no standard for me to > follow. > 2. They are all specified in html notation eg #FFFFFF which means that > they can be changed with sed without effecting the rest of the theme. > > If a standard can be come up with for doing this and people think it is > worthwhile i can probably fix them at a later date
After this commit the theme fails to build, locally and on jenkins. https://build.enlightenment.org/job/changely_elm_gcc_x86_64/lastFailedBuild/console 00:02:02.758 EDJ default.edj 00:02:03.707 edje_cc: Error. ../../data/themes/edc/xkbswitch.edc:31 got 1 arguments, but expected 4 00:02:03.707 edje_cc: Error. PARSE STACK: 00:02:03.708 collections.group.parts.part.description.color 00:02:03.708 edje_cc: Error. PARAMS: 00:02:03.708 edje_cc: Error. FN_COL_OUTLINE_TRANSPARENT 00:02:03.713 Makefile:1507: recipe for target 'default.edj' failed 00:02:03.713 make[3]: *** [default.edj] Error 255 regards Stefan Schmidt ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
