On 06/03/14 20:56, Davide Andreoli wrote: > 2014-03-02 21:07 GMT+01:00 Tom Hacohen <t...@stosb.com>: > >> Hey, >> >> I think this is unneeded as the information it'll provide is redundant. >> Doxygen documentation already includes the @deprecated (and added API, >> using @since). It's possible to get it from the docs. I don't think it's >> needed in the commit message as well. > > >> Since I consider @feature and @fix very important, I'd rather not overwhelm >> people with a whole set of things, and start it one step at a time. >> >> In conclusion: I think we should consider these tags in the future (1.11), >> but not overwhelm people for 1.10. >> > > I will then push for this again after 1.10, as I consider this very > important for 2 reason: > > 1. my mental sanity when I need to find out what has been added/deprecated > and need to be implemented in the bindings
I understand your pain, however, as I said, this information is available elsewhere, in an easily retrievable fashion. Also, something I haven't considered: Eolian should make it even easier to generate API changes for you. > > 2. will help to spot in time bad designed api, for example in 1.9 we added: > elm_win_wm_rotation_manual_rotation_done_set() > elm_win_wm_rotation_manual_rotation_done_get() > elm_win_wm_rotation_manual_rotation_done() > > This is a bad designed api as rotation_done is a property and a function at > the same time. This looks quite bad indeed. Wow. :) However, relying on people's commit messages for enforcing things (like reviewing API) is a recipe for disaster. Again, this is one of those things that Eolian will make easier and we anyway need a tool that checks what symbols we export, so we can review before release. -- Tom. ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
