I have researched this issue - but didn't get the reason. I'll try to fix it asap. Sorry for giving unstability. -----Original Message----- From: "Davide Andreoli"<d...@gurumeditation.it> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2014-03-11 (화) 05:48:04 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE.
2014-03-08 10:01 GMT+01:00 Davide Andreoli <dave>@gurumeditation.it>: > > 2014-03-07 9:33 GMT+01:00 woohyun <woo_hyun0705>@naver.com>: > > It would be much helpful if you can give the valgrind trace :) >> Only with the result of gdb, it's little bit hard to check ~ >> > > I do have the valgrid output but I now the segfault seems reproducible > also in the C elm test. > Please try: > elementary_test -to Photo > woohyun: so? any news about the issue? did you tested as I suggest? People are going to make a stable release and your commit is going to be included, but it is still broken. Please fix it asap or we will need to revert it. Thanks > > > >> >> -----Original Message----- >> From: "Davide Andreoli"<d...@gurumeditation.it> >> To: "Enlightenment developer list"& >> lt;enlightenment-devel@lists.sourceforge.net>; >> Cc: >> Sent: 2014-03-07 (금) 16:22:43 >> Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: replace >> EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE. >> >> 2014-03-06 23:28 GMT+01:00 Cedric BAIL <cedric.bail>@free.fr>: >> >> > On Thu, Mar 6, 2014 at 5:26 PM, Davide Andreoli & >> lt;dave>@gurumeditation.it> >> > wrote: >> > > 2014-02-27 2:36 GMT+01:00 WooHyun Jung & >> lt;wh0705.jung>@samsung.com>: >> > > >> > >> woohyun pushed a commit to branch master. >> > >> >> > >> >> > >> >> > >> http://git.enlightenment.org/core/efl.git/commit/?id=6093e68cb01cf915057b9e330f7586039d092990 >> ><http:>//git.enlightenment.org/core/efl.git/commit/?id=6093e68cb01cf915057b9e330f7586039d092990>>; >> >> >> > >> commit 6093e68cb01cf915057b9e330f7586039d092990 >> > >> Author: WooHyun Jung <wh0705.jung>@samsung.com> >> > >> Date: Thu Feb 27 10:31:42 2014 +0900 >> > >> >> > >> evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE. >> > >> >> > >> EINA_LIST_FREE does eina_list_remove_list, and >> clip_unset does >> > >> the same thing to the same list pointer. So, >> EINA_LIST_FOREACH_SAFE >> > >> is proper for this case. >> > >> --- >> > >> src/lib/evas/canvas/evas_object_main.c | 2 +- >> > >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> >> > >> diff --git a/src/lib/evas/canvas/evas_object_main.c >> > >> b/src/lib/evas/canvas/evas_object_main.c >> > >> index 9db95d4..d8d3850 100644 >> > >> --- a/src/lib/evas/canvas/evas_object_main.c >> > >> +++ b/src/lib/evas/canvas/evas_object_main.c >> > >> @@ -654,7 +654,7 @@ _destructor(Eo *eo_obj, void *_pd, >> va_list *list >> > >> EINA_UNUSED) >> > >> goto end; >> > >> } >> > >> evas_object_grabs_cleanup(eo_obj, obj); >> > >> - EINA_LIST_FREE(obj->clip.clipees, tmp) >> > >> + EINA_LIST_FOREACH_SAFE(obj->clip.clipees, l, l2, tmp) >> > >> evas_object_clip_unset(tmp->object); >> > >> EINA_LIST_FOREACH_SAFE(obj->proxy->proxies, l, >> l2, proxy) >> > >> evas_object_image_source_unset(proxy); >> > >> >> > > >> > > Weird, this commit is causing a segfault in the elementary >> photo test in >> > > python bindings...and in my Git user interface :( >> > > >> > > strangely the segfault seems not reproducible in the C photo >> test. >> > > >> > > The segfault is triggered when elm_object_style_set(photo, >> "shadow") is >> > > called. >> > > >> > > If I revert this commit the segfault goes away, I have no idea >> why this >> > is >> > > happening, can you please give a look? Or tell me what I can >> check >> > > >> > > This is the first part of the gdb backtrace: >> > >> > Would you have valgrind trace to ? >> > >> >> No, sorry, I never used valgrind in python apps, dunno how to make it. If >> it is really needed I can make a try this evening >> >> >> > -- >> > Cedric BAIL >> > >> > >> > >> ------------------------------------------------------------------------------ >> > Subversion Kills Productivity. Get off Subversion & Make the >> Move to >> > Perforce. >> > With Perforce, you get hassle-free workflows. Merge that actually >> works. >> > Faster operations. Version large binaries. Built-in WAN >> optimization and >> > the >> > freedom to use Git, Perforce or both. Make the move to Perforce. >> > >> > >> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk >> ><http:>//pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk>>; >> _______________________________________________ >> > enlightenment-devel mailing list >> > enlightenment-devel@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > <https:>//lists.sourceforge.net/lists/listinfo/enlightenment-devel>> >> ; >> >> ------------------------------------------------------------------------------ >> Subversion Kills Productivity. Get off Subversion & Make the Move to >> Perforce. >> With Perforce, you get hassle-free workflows. Merge that actually works. >> Faster operations. Version large binaries. Built-in WAN optimization and >> the >> freedom to use Git, Perforce or both. Make the move to Perforce. >> >> //pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk>">http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk<http:>//pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk> >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> >> ------------------------------------------------------------------------------ >> Subversion Kills Productivity. Get off Subversion & Make the Move to >> Perforce. >> With Perforce, you get hassle-free workflows. Merge that actually works. >> Faster operations. Version large binaries. Built-in WAN optimization and >> the >> freedom to use Git, Perforce or both. Make the move to Perforce. >> >> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
