On Tue, Mar 11, 2014 at 9:40 AM, Tom Hacohen <t...@stosb.com> wrote: > I wonder if this even handles pre-change code correctly. I.e code that > doesn't set color, thus having color be garbage. I bet it doesn't. This > should probably be reverted until properly fixed.
The structure is allocated from inside Eina, so it should not be a problem. > On Tue, Mar 11, 2014 at 12:29 AM, Cedric BAIL <cedric.b...@free.fr> wrote: > >> On Tue, Mar 11, 2014 at 1:51 AM, Tom Hacohen <t...@stosb.com> wrote: >> > tasn pushed a commit to branch master. >> > >> > >> http://git.enlightenment.org/core/efl.git/commit/?id=c6589ffc1929b920dbbe536c19a137678f1d3ce4 >> > >> > commit c6589ffc1929b920dbbe536c19a137678f1d3ce4 >> > Author: Tom Hacohen <t...@stosb.com> >> > Date: Mon Mar 10 16:50:03 2014 +0000 >> > >> > Eina Log: Fixed ABI break introduce by the addition of 'color'. >> > >> > ABI break was introduced here >> 5913ce7ec87beb267d2d02846e5267eae08ef860 >> > >> > Always add new members at the end of public structures. >> >> It would be good to also mark this field as being @since 1.10 or 1.9... >> >> > --- >> > src/lib/eina/eina_log.h | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/src/lib/eina/eina_log.h b/src/lib/eina/eina_log.h >> > index 70f9b40..c2ac46f 100644 >> > --- a/src/lib/eina/eina_log.h >> > +++ b/src/lib/eina/eina_log.h >> > @@ -413,13 +413,15 @@ typedef struct _Eina_Log_Domain Eina_Log_Domain; >> > struct _Eina_Log_Domain >> > { >> > int level; /**< Max level to log */ >> > - const char *color; /**< Color to use when printing in this domain */ >> > const char *domain_str; /**< Formatted string with color to print */ >> > const char *name; /**< Domain name */ >> > size_t namelen; /**< strlen(name) */ >> > >> > /* Private */ >> > Eina_Bool deleted : 1; /**< Flags deletion of domain, a free slot >> */ >> > + >> > + /* Add new members here. */ >> > + const char *color; /**< Color to use when printing in this domain */ >> > }; >> > >> > /** >> > >> > -- >> > >> > >> > >> >> >> >> -- >> Cedric BAIL >> >> >> ------------------------------------------------------------------------------ >> Learn Graph Databases - Download FREE O'Reilly Book >> "Graph Databases" is the definitive new guide to graph databases and their >> applications. Written by three acclaimed leaders in the field, >> this first edition is now available. Download your free book today! >> http://p.sf.net/sfu/13534_NeoTech >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Cedric BAIL ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
