stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=897b70437f49464e0f8815abcacc238f31f73a1d

commit 897b70437f49464e0f8815abcacc238f31f73a1d
Author: Stefan Schmidt <[email protected]>
Date:   Wed Mar 19 16:16:55 2014 +0100

    evas/engine/drm: Avoid shadow of a function parameter
    
    Having the same name for a parameter as well as a local var name could
    cause quite some problems. Better avoid it.
---
 src/lib/ecore_drm/ecore_drm_device.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/lib/ecore_drm/ecore_drm_device.c 
b/src/lib/ecore_drm/ecore_drm_device.c
index e6a790e..5df3918 100644
--- a/src/lib/ecore_drm/ecore_drm_device.c
+++ b/src/lib/ecore_drm/ecore_drm_device.c
@@ -248,7 +248,7 @@ ecore_drm_device_find(const char *name, const char *seat)
         /* try to allocate space for return device structure */
         if ((dev = calloc(1, sizeof(Ecore_Drm_Device))))
           {
-             const char *id, *seat;
+             const char *id, *seat_id;
 
              /* set device name */
              dev->drm.name = 
@@ -262,11 +262,11 @@ ecore_drm_device_find(const char *name, const char *seat)
              if ((id = udev_device_get_sysnum(tmpdevice)))
                dev->id = atoi(id);
 
-             /* set dev seat */
-             seat = udev_device_get_property_value(tmpdevice, "ID_SEAT");
-             if (!seat) seat = "seat0";
+             /* set dev seat_id */
+             seat_id = udev_device_get_property_value(tmpdevice, "ID_SEAT");
+             if (!seat_id) seat_id = "seat0";
 
-             dev->seat = eina_stringshare_add(seat);
+             dev->seat = eina_stringshare_add(seat_id);
 
              /* dev->format = GBM_FORMAT_XRGB8888; */
              dev->format = 0;

-- 


Reply via email to