On 20/03/14 09:17, Daniel Zaoui wrote: > On 03/20/2014 11:01 AM, Tom Hacohen wrote: >> On 20/03/14 03:55, WooHyun Jung wrote: >>> woohyun pushed a commit to branch master. >>> >>> http://git.enlightenment.org/core/elementary.git/commit/?id=6c05e867896eb998730cb92af94a4d56d4d8fe9c >>> >>> commit 6c05e867896eb998730cb92af94a4d56d4d8fe9c >>> Author: WooHyun Jung <wh0705.j...@samsung.com> >>> Date: Thu Mar 20 12:55:28 2014 +0900 >>> >>> elm_widget: Restore removed codes while eolian work. >>> --- >>> src/lib/elm_widget.c | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c >>> index 25f1786..a212099 100644 >>> --- a/src/lib/elm_widget.c >>> +++ b/src/lib/elm_widget.c >>> @@ -2841,7 +2841,13 @@ _elm_widget_focus_region_get(Eo *obj, >>> Elm_Widget_Smart_Data *_pd EINA_UNUSED, Ev >>> { >>> Eina_Bool int_ret = EINA_FALSE; >>> eo_do((Eo *)obj, elm_obj_widget_on_focus_region(x, y, w, h, >>> &int_ret)); >>> - return int_ret; >>> + if (!int_ret) >>> + { >>> + evas_object_geometry_get(obj, NULL, NULL, w, h); >>> + if (x) *x = 0; >>> + if (y) *y = 0; >>> + } >>> + return EINA_TRUE; >>> } >>> >>> EOLIAN static void >>> >> If this behaviour is wanted, why not add it to the actual function >> implementation? > > He added it right, i.e in the function invoked by Eolian. > > I will take a look again at my patch in elm_widget.c, to be sure there > is no missed code part. >
So all of what this eo function does is call another eo function? That's odd. -- Tom. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel