raster pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=22306ec3a87954041779bdc7568a61d65e2bf86a
commit 22306ec3a87954041779bdc7568a61d65e2bf86a Author: Amitesh Singh <[email protected]> Date: Fri Apr 4 12:04:04 2014 +0900 list/genlist/gengrid/toolbar: Fix - _nearest_visible_item_get() should always return an item. Test Plan: Bug: - elementary_test->genlist/list/toolbar/gengrid Focus - Resize the window to a state when no item is fully visible. only partially visible. - Move Focus from outer widgets (Up/Down/Left/right buttons) to list/genlist/gengrid/toolbar. - Focus goes away (size - 0). Reason: _nearest_visible_item_get returns NULL. @fix Reviewers: seoz, raster, woohyun Reviewed By: raster CC: seoz, nirajkr, anand.km Differential Revision: https://phab.enlightenment.org/D696 --- src/lib/elm_gengrid.c | 2 +- src/lib/elm_genlist.c | 2 +- src/lib/elm_list.c | 2 +- src/lib/elm_toolbar.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c index 0cbd598..7e60565 100644 --- a/src/lib/elm_gengrid.c +++ b/src/lib/elm_gengrid.c @@ -2171,7 +2171,7 @@ _elm_gengrid_nearest_visible_item_get(Evas_Object *obj, Elm_Object_Item *it) return item; } } - return NULL; + return it; } EOLIAN static Eina_Bool diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c index 32b7d7b..b567fbd 100644 --- a/src/lib/elm_genlist.c +++ b/src/lib/elm_genlist.c @@ -2808,7 +2808,7 @@ _elm_genlist_nearest_visible_item_get(Evas_Object *obj, Elm_Object_Item *it) return item; } } - return NULL; + return it; } EOLIAN static Eina_Bool diff --git a/src/lib/elm_list.c b/src/lib/elm_list.c index 43b9e9e..0694b0e 100644 --- a/src/lib/elm_list.c +++ b/src/lib/elm_list.c @@ -1201,7 +1201,7 @@ _elm_list_nearest_visible_item_get(Evas_Object *obj, Elm_Object_Item *it) return item; } } - return NULL; + return it; } EOLIAN static Eina_Bool diff --git a/src/lib/elm_toolbar.c b/src/lib/elm_toolbar.c index 6c3fbc3..8b6562e 100644 --- a/src/lib/elm_toolbar.c +++ b/src/lib/elm_toolbar.c @@ -694,7 +694,7 @@ _elm_toolbar_nearest_visible_item_get(Evas_Object *obj, Elm_Object_Item *it) return item; } } - return NULL; + return it; } EOLIAN static Eina_Bool --
