This commit also needs to be revised wholely. Direction key press should move the focus only and in a focus change, we should check if we need to select an item optionally. I may need to fix it later.
Daniel Juyung Seo (SeoZ) On Sat, Apr 5, 2014 at 12:53 AM, Daniel Juyung Seo <[email protected]>wrote: > Hi > > On Fri, Apr 4, 2014 at 11:06 PM, Amitesh Singh <[email protected]>wrote: > >> Hi >> >> The name of the flag is confusing. >> It should be named as 'item selection on focus'. >> > > Yes the name was wrong. > > >> 1. Selection will trigger focus >> > > Yes this is fixed. > > >> 2. Focus won't trigger Selection. A return/space key press will trigger >> selection on focus. ~~~ I will fix this. >> >> > This must be optional as there was no separation between focus and > selection previously. > So the name should be "elm_config_item_select_on_focus_disabled_set/get()" > as it is enabled by default. > > Thanks for the correction. > > Daniel Juyung Seo (SeoZ) > > > >> Thanks >> >> sent via galaxy note. >> On Apr 3, 2014 7:09 PM, "Iván Briano" <[email protected]> wrote: >> >> > On Thu, Apr 3, 2014 at 7:10 AM, Amitesh Singh <[email protected]> >> > wrote: >> > > raster pushed a commit to branch master. >> > > >> > > >> > >> http://git.enlightenment.org/core/elementary.git/commit/?id=bb1e8afde417aa2fa43c2ad4819bee5a3f9c98cb >> > > >> > > commit bb1e8afde417aa2fa43c2ad4819bee5a3f9c98cb >> > > Author: Amitesh Singh <[email protected]> >> > > Date: Thu Apr 3 19:11:57 2014 +0900 >> > > >> > > focus: Added optional focus feature - item focus on selection. >> > > >> > > Summary: >> > > Currenly focus and selection happens together. This patch makes >> item >> > focus >> > > on selection optional by configuration and API. >> > > >> > > - configuration: "item_focus_on_selection". >> > > - API: elm_config_item_focus_on_selection_get/set. >> > > - Implemented item_focus_on_selection feature in elm list. >> > > @feature >> > >> > So, let's see if I get this right. When we give focus to a list, it >> > will automatically >> > select the first item, thus triggering its callback and in some cases >> > never allowing >> > the user an option (I patched ctxpopup to not give focus to the inner >> > list for exactly >> > this problem). >> > Now we have an option to not focus the item when it is selected, but >> > the other case, >> > which is the really problematic one is still there. Are there plans on >> > fixing this any time soon? >> > >> > >> > >> ------------------------------------------------------------------------------ >> > _______________________________________________ >> > enlightenment-devel mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
