2014-04-07 11:17 GMT+02:00 Daniel Zaoui <daniel.za...@samsung.com>: > Hi boyz, > > I don't have any problem to rename the stuff. We named it in that way > because the filenames were named in this way. > > So my question is: what is the purpose of elc_, els_... if not to > distinguish them from regular widgets? >
For what I know there are no real purpose for that naming, so I suggest to change back the class names to be all elm_ prefixed > > Jack, DanielZ > > > On 04/06/2014 01:36 PM, Cedric BAIL wrote: > > Cedric Bail > > On Apr 6, 2014 6:19 PM, "Davide Andreoli" <d...@gurumeditation.it> > wrote: > >> 2014-04-05 5:55 GMT+02:00 Kai Huuhko <kai.huu...@gmail.com>: > >> > >>> kuuko pushed a commit to branch master. > >>> > >>> > >>> > > > http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=78442b6e9dd8a6e7111c298ae6588faa612111b1 > >>> commit 78442b6e9dd8a6e7111c298ae6588faa612111b1 > >>> Author: Kai Huuhko <kai.huu...@gmail.com> > >>> Date: Sat Apr 5 06:53:56 2014 +0300 > >>> > >>> Follow Eolian wrt. widget naming > >>> > >> Shouldn't this be fixed in Eolian itself ? really we want class names > as: > >> Elc_Fileselector, Elc_Hoversel, etc ?? > >> > >> Note the prefix: was Elm_ , now is Elc_ > >> > >> is this really wanted, or maybe an error in the Eolian transition? > > Not a fan of that naming either. > > > >>> --- > >>> efl/elementary/ctxpopup.pyx | 4 ++-- > >>> efl/elementary/fileselector.pyx | 2 +- > >>> efl/elementary/fileselector_button.pyx | 2 +- > >>> efl/elementary/fileselector_entry.pyx | 2 +- > >>> efl/elementary/hoversel.pyx | 4 ++-- > >>> efl/elementary/multibuttonentry.pyx | 2 +- > >>> efl/elementary/naviframe.pyx | 2 +- > >>> efl/elementary/popup.pyx | 2 +- > >>> efl/elementary/video.pyx | 2 +- > >>> 9 files changed, 11 insertions(+), 11 deletions(-) > >>> > >>> diff --git a/efl/elementary/ctxpopup.pyx b/efl/elementary/ctxpopup.pyx > >>> index 26e560c..ab36d02 100644 > >>> --- a/efl/elementary/ctxpopup.pyx > >>> +++ b/efl/elementary/ctxpopup.pyx > >>> @@ -322,7 +322,7 @@ cdef class Ctxpopup(LayoutClass): > >>> Use this property when you want ctxpopup not to hide > >>> automatically. > >>> By default, ctxpopup is dismissed whenever mouse clicked its > >>> background > >>> area, language is changed, and its parent geometry is > >>> updated(changed). > >>> - > >>> + > >>> :type: bool > >>> > >>> .. versionadded:: 1.9 > >>> @@ -373,4 +373,4 @@ cdef class Ctxpopup(LayoutClass): > >>> def callback_unfocused_del(self, func): > >>> self._callback_del("unfocused", func) > >>> > >>> -_object_mapping_register("Elm_Ctxpopup", Ctxpopup) > >>> +_object_mapping_register("Elc_Ctxpopup", Ctxpopup) > >>> diff --git a/efl/elementary/fileselector.pyx > >>> b/efl/elementary/fileselector.pyx > >>> index 1c7246b..ceb79e4 100644 > >>> --- a/efl/elementary/fileselector.pyx > >>> +++ b/efl/elementary/fileselector.pyx > >>> @@ -592,4 +592,4 @@ cdef class Fileselector(LayoutClass): > >>> self._callback_del_full("done", _cb_string_conv, func) > >>> > >>> > >>> -_object_mapping_register("Elm_Fileselector", Fileselector) > >>> +_object_mapping_register("Elc_Fileselector", Fileselector) > >>> diff --git a/efl/elementary/fileselector_button.pyx > >>> b/efl/elementary/fileselector_button.pyx > >>> index 2b89245..82b633a 100644 > >>> --- a/efl/elementary/fileselector_button.pyx > >>> +++ b/efl/elementary/fileselector_button.pyx > >>> @@ -295,4 +295,4 @@ cdef class FileselectorButton(Button): > >>> def callback_language_changed_del(self, func): > >>> self._callback_del("language,changed", func) > >>> > >>> -_object_mapping_register("Elm_Fileselector_Button", > FileselectorButton) > >>> +_object_mapping_register("Elc_Fileselector_Button", > FileselectorButton) > >>> diff --git a/efl/elementary/fileselector_entry.pyx > >>> b/efl/elementary/fileselector_entry.pyx > >>> index d95a5b4..42a9bf7 100644 > >>> --- a/efl/elementary/fileselector_entry.pyx > >>> +++ b/efl/elementary/fileselector_entry.pyx > >>> @@ -431,4 +431,4 @@ cdef class FileselectorEntry(LayoutClass): > >>> def callback_language_changed_del(self, func): > >>> self._callback_del("language,changed", func) > >>> > >>> -_object_mapping_register("Elm_Fileselector_Entry", FileselectorEntry) > >>> +_object_mapping_register("Elc_Fileselector_Entry", FileselectorEntry) > >>> diff --git a/efl/elementary/hoversel.pyx b/efl/elementary/hoversel.pyx > >>> index 5f20d9d..2c9ca98 100644 > >>> --- a/efl/elementary/hoversel.pyx > >>> +++ b/efl/elementary/hoversel.pyx > >>> @@ -394,7 +394,7 @@ cdef class Hoversel(Button): > >>> > >>> def callback_expanded_add(self, func, *args, **kwargs): > >>> """The hover is expanded. > >>> - > >>> + > >>> .. versionadded:: 1.9 > >>> > >>> """ > >>> @@ -404,4 +404,4 @@ cdef class Hoversel(Button): > >>> self._callback_del("expanded", func) > >>> > >>> > >>> -_object_mapping_register("Elm_Hoversel", Hoversel) > >>> +_object_mapping_register("Elc_Hoversel", Hoversel) > >>> diff --git a/efl/elementary/multibuttonentry.pyx > >>> b/efl/elementary/multibuttonentry.pyx > >>> index 9d3d5e9..e1537f8 100644 > >>> --- a/efl/elementary/multibuttonentry.pyx > >>> +++ b/efl/elementary/multibuttonentry.pyx > >>> @@ -533,4 +533,4 @@ cdef class MultiButtonEntry(Object): > >>> self._callback_del("expand,state,changed", func) > >>> > >>> > >>> -_object_mapping_register("Elm_Multibuttonentry", MultiButtonEntry) > >>> +_object_mapping_register("Elc_Multibuttonentry", MultiButtonEntry) > >>> diff --git a/efl/elementary/naviframe.pyx > b/efl/elementary/naviframe.pyx > >>> index ecf23e2..63b4158 100644 > >>> --- a/efl/elementary/naviframe.pyx > >>> +++ b/efl/elementary/naviframe.pyx > >>> @@ -601,4 +601,4 @@ cdef class Naviframe(LayoutClass): > >>> def callback_unfocused_del(self, func): > >>> self._callback_del("unfocused", func) > >>> > >>> -_object_mapping_register("Elm_Naviframe", Naviframe) > >>> +_object_mapping_register("Elc_Naviframe", Naviframe) > >>> diff --git a/efl/elementary/popup.pyx b/efl/elementary/popup.pyx > >>> index 08349d0..40f6935 100644 > >>> --- a/efl/elementary/popup.pyx > >>> +++ b/efl/elementary/popup.pyx > >>> @@ -440,4 +440,4 @@ cdef class Popup(LayoutClass): > >>> self._callback_del("language,changed", func) > >>> > >>> > >>> -_object_mapping_register("Elm_Popup", Popup) > >>> +_object_mapping_register("Elc_Popup", Popup) > >>> diff --git a/efl/elementary/video.pyx b/efl/elementary/video.pyx > >>> index 21e6ac6..e241800 100644 > >>> --- a/efl/elementary/video.pyx > >>> +++ b/efl/elementary/video.pyx > >>> @@ -369,4 +369,4 @@ cdef class Player(LayoutClass): > >>> def callback_unfocused_del(self, func): > >>> self._callback_del("unfocused", func) > >>> > >>> -_object_mapping_register("Elm_Player", Player) > >>> +_object_mapping_register("Elc_Player", Player) > >>> > >>> -- > >>> > >>> > >>> > > > ------------------------------------------------------------------------------ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > ------------------------------------------------------------------------------ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > ------------------------------------------------------------------------------ > Put Bad Developers to Shame > Dominate Development with Jenkins Continuous Integration > Continuously Automate Build, Test & Deployment > Start a new project now. Try Jenkins in the cloud. > http://p.sf.net/sfu/13600_Cloudbees_APR > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
