jpeg pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=356939a8fdd7b7e30acfb0826d5c37d5661da179
commit 356939a8fdd7b7e30acfb0826d5c37d5661da179
Author: Jean-Philippe Andre <jp.an...@samsung.com>
Date: Fri Apr 18 18:32:20 2014 +0900
Evas: Add comments to the TGV saver (FIXME)
The block size has a visual effect. This is obviously a bug.
---
src/modules/evas/savers/tgv/evas_image_save_tgv.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/src/modules/evas/savers/tgv/evas_image_save_tgv.c
b/src/modules/evas/savers/tgv/evas_image_save_tgv.c
index b1a52b7..357dfff 100644
--- a/src/modules/evas/savers/tgv/evas_image_save_tgv.c
+++ b/src/modules/evas/savers/tgv/evas_image_save_tgv.c
@@ -45,21 +45,16 @@ evas_image_save_file_tgv(RGBA_Image *im,
// Disable dithering, as it will deteriorate the quality of flat surfaces
param.m_dithering = 0;
+ // FIXME: Depending on the block size, we have some distortion of the image
+ // Usually, one or two pixels on the top & left borders are removed
+ block = 6;
+
if (quality > 95)
- {
- param.m_quality = rg_etc1_high_quality;
- block = 7;
- }
+ param.m_quality = rg_etc1_high_quality;
else if (quality > 30)
- {
- param.m_quality = rg_etc1_medium_quality;
- block = 6;
- }
+ param.m_quality = rg_etc1_medium_quality;
else
- {
- param.m_quality = rg_etc1_low_quality;
- block = 5;
- }
+ param.m_quality = rg_etc1_low_quality;
header[4] = (block << 4) | block;
header[5] = 0;
--
