Pushed. Thanks for the confirmation and fix! Daniel Juyung Seo (SeoZ)
On Wed, Apr 23, 2014 at 5:28 PM, Lukasz Stanislawski < [email protected]> wrote: > Hello Daniel, > > It is unintendent, looks like copy&paste bug. Please check: > https://phab.enlightenment.org/D781. > > Best regards, > Lukasz Stanislawski > > W dniu 23.04.2014 05:07, Daniel Juyung Seo pisze: > >> Dear Lukasz Stanislawksi, >> >> >> On Mon, Apr 21, 2014 at 3:03 PM, Lukasz Stanislawski >> <[email protected] <mailto:[email protected]>> wrote: >> >> raster pushed a commit to branch master. >> >> http://git.enlightenment.org/core/elementary.git/commit/?id= >> fbd30582d45717525e13ed961a46f97c28166b68 >> >> commit fbd30582d45717525e13ed961a46f97c28166b68 >> Author: Lukasz Stanislawski <[email protected] >> <mailto:[email protected]>> >> >> Date: Mon Apr 21 15:04:25 2014 +0900 >> >> atspi: Atspi_Action interface implementation @feature >> >> Summary: Enables remote execution of elementary widget actions. >> >> Test Plan: build&install, accerrsiser tests on ubuntu 12.04 >> >> Reviewers: raster, seoz >> >> Differential Revision: https://phab.enlightenment.org/D747 >> --- >> >> >> @@ -1616,6 +1802,10 @@ static void _object_register(Eo *obj, char >> *path) >> >> eo_do(obj, eo_event_callback_array_add(_window_cb(), >> infc)); >> } >> + if (eo_isa(obj, ELM_INTERFACE_ATSPI_ACTION_CLASS)) >> + { >> + infc = eldbus_service_interface_register(_a11y_bus, >> path, &action_iface_desc); >> + } >> } >> >> >> You did not use infc even thought you get the return value from >> eldbus_service_interface_register. >> Is it intended? >> >> Please check that. There is a coverity report about this. >> https://scan6.coverity.com:8443/reports.htm#v17772/p10305/fileInstanceId= >> 13164120&defectInstanceId=4586798&mergedDefectId=657321 >> >> Thanks. >> >> Daniel Juyung Seo (SeoZ) >> >> } >> >> ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
