tasn pushed a commit to branch efl-1.10.

http://git.enlightenment.org/core/efl.git/commit/?id=63ee6cf46bad47fe0d05f8891a111def20443c89

commit 63ee6cf46bad47fe0d05f8891a111def20443c89
Author: Tom Hacohen <[email protected]>
Date:   Tue May 27 14:18:40 2014 +0100

    Evas textblock: Fix wrong advance calculation when bidi is disabled.
    
    The last_it was not updated correctly with bidi disabled.
    
    Thanks to Daniel Hirt for spotting this.
    
    @fix
---
 src/lib/evas/canvas/evas_object_textblock.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lib/evas/canvas/evas_object_textblock.c 
b/src/lib/evas/canvas/evas_object_textblock.c
index 1fed2607..bc0430d 100644
--- a/src/lib/evas/canvas/evas_object_textblock.c
+++ b/src/lib/evas/canvas/evas_object_textblock.c
@@ -10320,10 +10320,9 @@ _size_native_calc_line_finalize(const Evas_Object 
*eo_obj, Eina_List *items,
 loop_advance:
         *w += it->adv;
 
+        /* Only conditional if we have bidi support, otherwise, just set it. */
 #ifdef BIDI_SUPPORT
         if (!last_it || (it->visual_pos > last_it->visual_pos))
-#else
-        if (!last_it)
 #endif
           {
              last_it = it;

-- 


Reply via email to