jackdanielz pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=97913753ea8dbb9eb544e69c96f4fbabe9347427
commit 97913753ea8dbb9eb544e69c96f4fbabe9347427
Author: Daniel Zaoui <daniel.za...@samsung.com>
Date: Thu Jun 5 07:38:58 2014 +0300
Eolian: Fix Coverity issue.
In a certain case, the function was returning without releasing all the
resources.
CID 1220084
---
src/bin/eolian/impl_generator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/bin/eolian/impl_generator.c b/src/bin/eolian/impl_generator.c
index 7083e9f..d3ec76e 100644
--- a/src/bin/eolian/impl_generator.c
+++ b/src/bin/eolian/impl_generator.c
@@ -133,7 +133,7 @@ _prototype_generate(Eolian_Function foo,
Eolian_Function_Type ftype, Eina_Strbuf
impl_desc?impl_name:class_env.lower_classname,
eolian_function_name_get(foo),
ftype == EOLIAN_PROP_GET?"_get": (ftype ==
EOLIAN_PROP_SET?"_set":""));
- if (_function_exists(func_name, buffer)) return EINA_TRUE;
+ if (_function_exists(func_name, buffer)) goto end;
printf("Generation of function %s\n", func_name);
const char *rettype = eolian_function_return_type_get(foo, ftype);
@@ -175,6 +175,7 @@ _prototype_generate(Eolian_Function foo,
Eolian_Function_Type ftype, Eina_Strbuf
eina_strbuf_string_get(super_invok)
);
+end:
eina_strbuf_free(short_params);
eina_strbuf_free(params);
eina_strbuf_free(super_invok);
--
