raster pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=ff86435a523e6971cb933727dcf2f5fa3dd0bd87

commit ff86435a523e6971cb933727dcf2f5fa3dd0bd87
Author: Lukasz Stanislawski <[email protected]>
Date:   Wed Jun 11 16:05:54 2014 +0900

    atspi: typo fix, avoid returning w/o va_end call
    
    Summary:
    CID: 1222462
    CID: 1222461
    CID: 1222465
    
    Reviewers: raster, seoz, z.kosinski
    
    Differential Revision: https://phab.enlightenment.org/D995
---
 src/lib/elm_atspi_bridge.c | 4 ++--
 src/lib/elm_entry.c        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/elm_atspi_bridge.c b/src/lib/elm_atspi_bridge.c
index 427645f..c1f1ad5 100644
--- a/src/lib/elm_atspi_bridge.c
+++ b/src/lib/elm_atspi_bridge.c
@@ -2979,7 +2979,6 @@ static void _object_signal_send(Eldbus_Service_Interface 
*infc, int sig_id, cons
    Eldbus_Message *msg;
    Eldbus_Message_Iter *iter , *viter;
    va_list va;
-   va_start(va, variant_sig);
 
    EINA_SAFETY_ON_NULL_RETURN(infc);
    EINA_SAFETY_ON_NULL_RETURN(minor);
@@ -2987,8 +2986,9 @@ static void _object_signal_send(Eldbus_Service_Interface 
*infc, int sig_id, cons
    msg = eldbus_service_signal_new(infc, sig_id);
    EINA_SAFETY_ON_NULL_RETURN(msg);
 
-   iter = eldbus_message_iter_get(msg);
+   va_start(va, variant_sig);
 
+   iter = eldbus_message_iter_get(msg);
    eldbus_message_iter_arguments_append(iter, "sii", minor, det1, det2);
 
    if (variant_sig)
diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index 9f9fd99..858ed7c 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -5034,7 +5034,7 @@ _elm_entry_elm_interface_atspi_text_string_get(Eo *obj, 
Elm_Entry_Data *_pd EINA
 
    cur = evas_object_textblock_cursor_new(tblk);
    cur2 = evas_object_textblock_cursor_new(tblk);
-   if (!cur2 || !cur2) goto fail;
+   if (!cur || !cur2) goto fail;
 
    evas_textblock_cursor_pos_set(cur, *start_offset);
    if (evas_textblock_cursor_pos_get(cur) != *start_offset) goto fail;
@@ -5112,7 +5112,7 @@ _elm_entry_elm_interface_atspi_text_text_get(Eo *obj, 
Elm_Entry_Data *_pd EINA_U
 
    cur = evas_object_textblock_cursor_new(tblk);
    cur2 = evas_object_textblock_cursor_new(tblk);
-   if (!cur2 || !cur2) goto fail;
+   if (!cur || !cur2) goto fail;
 
    evas_textblock_cursor_pos_set(cur, start_offset);
    if (evas_textblock_cursor_pos_get(cur) != start_offset) goto fail;

-- 


Reply via email to