Coverage doesn't work for me without it, and yes, I have tested it. Also, I looked at it, and it looks correct. We have sources in both srcdir and builddir, and both paths were relative to srcdir, not srcdir/src here. Honestly though, lcov is so broken it's not even funny. Try and look at the docs. You can't have more than 1 search path, and they support "auto search path" which doesn't really work.
If you say it fixes it for jenkins, fine, do it. However, it's still broken here, with builddir == srcdir/build (i.e build/ inside the repo). -- Tom. On 19/06/14 14:41, Stefan Schmidt wrote: > stefan pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=2cebf6785eed26e3f4eda7b6d3d77954a19d3bfc > > commit 2cebf6785eed26e3f4eda7b6d3d77954a19d3bfc > Author: Stefan Schmidt <s.schm...@samsung.com> > Date: Thu Jun 19 15:36:01 2014 +0200 > > Revert "Coverage: Fix base directory." > > This reverts commit 842e8e9fa01f2ce0c217dec2578d5ee3e0911a8b. > > Scratching my head over this for a long time now. It sneaked in when > jenkins nightly builds which generates coverage reports was broken > due to newer gettext error handling. After that was fixed the build > kept being broken but now in coverage generation. > > Finnaly found this change. Why was it done? Did you actually test it? > Coverage generation worked fine on my local system as well as on > jenkins when I worked on this. If it is broken for you we might need > to have another look, but not by breaking jenkins. > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index b878020..010e9e6 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -384,7 +384,7 @@ lcov-reset: > > lcov-report: > @mkdir $(top_builddir)/coverage > - lcov --capture --compat-libtool --no-external --output-file > $(top_builddir)/coverage/coverage.info --directory $(top_builddir) > --base-directory $(top_srcdir) > + lcov --capture --compat-libtool --no-external --output-file > $(top_builddir)/coverage/coverage.info --directory $(top_builddir) > --base-directory $(top_srcdir)/src/ > lcov --remove $(top_builddir)/coverage/coverage.info '*.h' > --output-file $(top_builddir)/coverage/coverage.cleaned.info > lcov --remove $(top_builddir)/coverage/coverage.cleaned.info > '*/tests/*' --output-file $(top_builddir)/coverage/coverage.cleaned2.info > lcov --remove $(top_builddir)/coverage/coverage.cleaned2.info '*NONE*' > --output-file $(top_builddir)/coverage/coverage.cleaned3.info > ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
