cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=7c8764bf3976398ac83b533433e86838c0eaa0e0

commit 7c8764bf3976398ac83b533433e86838c0eaa0e0
Author: Kateryna Fesyna <[email protected]>
Date:   Mon Jun 23 11:18:59 2014 +0200

    edje: Edje_Edit - add missed iterator and object deletion in 
_delete_play_actions() function
    
    Summary:
    this commit adds missed eina_iterator_free() and evas_object_del() calls
    in _delete_play_actions() functions.
    
    @feature
    
    Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v, tasn
    
    Reviewed By: reutskiy.v.v
    
    CC: reutskiy.v.v, cedric
    
    Differential Revision: https://phab.enlightenment.org/D1059
    
    Signed-off-by: Cedric BAIL <[email protected]>
---
 src/lib/edje/edje_edit.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c
index aa84165..a908b32 100644
--- a/src/lib/edje/edje_edit.c
+++ b/src/lib/edje/edje_edit.c
@@ -971,11 +971,17 @@ _delete_play_actions(Evas_Object *obj, const char* name, 
int action_type, Eet_Fi
           return EINA_FALSE;
 
         if (!edje_object_file_set(eeo, ed->file->path, pce->entry))
-          continue;
+          {
+             evas_object_del(eeo);
+             continue;
+          }
 
         programs_list = edje_edit_programs_list_get(eeo);
         if (!programs_list)
-          continue;
+          {
+             evas_object_del(eeo);
+             continue;
+          }
 
         eed = eo_data_scope_get(eeo, EDJE_CLASS);
         for (i = 0; i < eed->collection->patterns.table_programs_size; i++)
@@ -1008,7 +1014,10 @@ _delete_play_actions(Evas_Object *obj, const char* name, 
int action_type, Eet_Fi
           }
         if (is_collection_changed)
           _edje_edit_collection_save(eetf, eed->collection);
+        evas_object_del(eeo);
      }
+
+   eina_iterator_free(it);
    return EINA_TRUE;
 }
 

-- 


Reply via email to