q66 pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=892c5cba5f75a398349a47ce39f891dfde4a69b4
commit 892c5cba5f75a398349a47ce39f891dfde4a69b4 Author: Daniel Kolesa <[email protected]> Date: Wed Jul 9 10:19:36 2014 +0100 eolian: fix coverity defects --- src/bin/eolian/main.c | 2 +- src/lib/eolian/eo_parser.c | 2 +- src/lib/eolian/eolian_database.c | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/bin/eolian/main.c b/src/bin/eolian/main.c index e88e8a3..38f892a 100644 --- a/src/bin/eolian/main.c +++ b/src/bin/eolian/main.c @@ -143,7 +143,7 @@ _generate_impl_c_file(char *filename, const Eolian_Class class) ERR("Couldnt allocate memory for file %s", filename); goto end; } - if (0 == fread(content, file_size, 1, fd)) + if (!fread(content, file_size, 1, fd)) { ERR("Couldnt read the %ld bytes of file %s", file_size, filename); free(content); diff --git a/src/lib/eolian/eo_parser.c b/src/lib/eolian/eo_parser.c index 33d7512..45f89e1 100644 --- a/src/lib/eolian/eo_parser.c +++ b/src/lib/eolian/eo_parser.c @@ -357,7 +357,7 @@ parse_typedef(Eo_Lexer *ls) check(ls, TOK_VALUE); ls->tmp.typedef_def->alias = eina_stringshare_add(ls->t.value); eo_lexer_get(ls); - test_next(ls, ':'); + (void)!!test_next(ls, ':'); ls->tmp.typedef_def->type = parse_type_struct_nonvoid(ls, EINA_TRUE, EINA_TRUE); ls->tmp.type_def = NULL; diff --git a/src/lib/eolian/eolian_database.c b/src/lib/eolian/eolian_database.c index 562b6e4..d8a4d48 100644 --- a/src/lib/eolian/eolian_database.c +++ b/src/lib/eolian/eolian_database.c @@ -1628,12 +1628,15 @@ static char * join_path(const char *path, const char *file) { Eina_Strbuf *buf = eina_strbuf_new(); + char *ret; eina_strbuf_append(buf, path); eina_strbuf_append_char(buf, '/'); eina_strbuf_append(buf, file); - return eina_strbuf_string_steal(buf); + ret = eina_strbuf_string_steal(buf); + eina_strbuf_free(buf); + return ret; } static void --
