devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=61847abae13e4ae30c3351330b580402209de228
commit 61847abae13e4ae30c3351330b580402209de228 Author: MinJeong Kim <[email protected]> Date: Wed Jul 9 09:06:58 2014 -0400 ecore-wayland: Do not destroy data_source for selection on client side Summary: Wayland client doesn't need to destroy previous data_source when client requests for selection_set, because there is "cancelled" event by wayland server to notify clients that the data_source is not used more and has to be destroyed. Before receiving the "cancelled" event, client cannot recognize that it is useless or not. Even if the client wants to create new data_source, wayland server can choose previous data_source rather than new one. Test Plan: 1. Launch weston 2. Launch "elementary_test -to entry5" on weston 3. Try to copy & paste Reviewers: devilhorns CC: cedric, gwanglim Differential Revision: https://phab.enlightenment.org/D1152 --- src/lib/ecore_wayland/ecore_wl_dnd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lib/ecore_wayland/ecore_wl_dnd.c b/src/lib/ecore_wayland/ecore_wl_dnd.c index 1b249b4..875cf5d 100644 --- a/src/lib/ecore_wayland/ecore_wl_dnd.c +++ b/src/lib/ecore_wayland/ecore_wl_dnd.c @@ -127,8 +127,6 @@ ecore_wl_dnd_selection_set(Ecore_Wl_Input *input, const char **types_offered) wl_array_init(&input->data_types); } - /* destroy any existing data source */ - if (input->data_source) wl_data_source_destroy(input->data_source); input->data_source = NULL; if (!types_offered[0]) return EINA_FALSE; --
