On Thu, Jul 10, 2014 at 9:55 AM, Stefan Schmidt <ste...@datenfreihafen.org> wrote: > Hello. > > On Thu, 2014-07-10 at 14:40, Cedric BAIL wrote: >> On Thu, Jul 10, 2014 at 1:32 PM, Stefan Schmidt >> <ste...@datenfreihafen.org> wrote: >> > Hello. >> > >> > On Thu, 2014-07-10 at 13:10, Cedric BAIL wrote: >> >> On Thu, Jul 10, 2014 at 12:12 PM, Stefan Schmidt >> >> <ste...@datenfreihafen.org> wrote: >> >> > Hello. >> >> > >> >> > On Thu, 2014-07-10 at 01:44, ms wrote: >> >> >> cedric pushed a commit to branch master. >> >> >> >> >> >> http://git.enlightenment.org/core/efl.git/commit/?id=ce8d67922fcd9d18b887f17c29cdd5749eafecd0 >> >> >> >> >> >> commit ce8d67922fcd9d18b887f17c29cdd5749eafecd0 >> >> >> Author: ms <ms.g...@samsung.com> >> >> >> Date: Thu Jul 10 10:39:06 2014 +0200 >> >> >> >> >> >> test_test >> >> >> >> >> >> Reviewers: kimcinoo >> >> >> >> >> >> Reviewed By: kimcinoo >> >> >> >> >> >> Subscribers: kimcinoo, cedric >> >> >> >> >> >> Differential Revision: https://phab.enlightenment.org/D1153 >> >> > >> >> > Is this really what we expect from a commit message? Sure its a test >> >> > for finding the test but "test_test" is not what I expect. >> >> >> >> Me to, got tricked by arcanist again on that one. Sorry. Just looked >> >> at the code... Will pay more attention at the commit message next >> >> time. >> > >> > What did phab do this time? >> > >> > We already have two pitfalls with the review system: >> > 1) Author name gets replaces with phab name >> >> Oh, didn't know that one. > > It was the reason for ann this efl.none author name commits we got. > The phab account was setup and replaced what the git diff had in it. > Review was ok, but in git it showed the srewed up config. > >> > 2) Whit space changes get ignored >> >> That one was fixed. > > Did we verify that? I know that Tom changed something and I haven't > seen something similar since. Might be gone for good. > >> > Both already hit us before. Is there another ptifall about the commit >> > messages? >> >> Me not looking at it. > > Haha, not really a tool problem in that case I guess. :) >
Unless we have the same problem with the name. If you can submit a proper description when you send the patch with arc, it may appear on phab all decent and pretty and mask the fact that the actual commit message is lacking. In both cases, it boils down to verifying that everything's right before pushing, from the point of view of the integrator, but we should encourage submitters to use git properly. > regards > Stefan Schmidt > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
