2014-07-19 15:16 GMT+01:00 Tom Hacohen <[email protected]>: > Shitty commit message. While I personally hate the "ouch" and "*spanks > myself*" in commit messages in general, it would have been acceptable in > the description had you used a normal commit message for the > description. This is just useless. Looking at the diff you can't find > the bug and have no idea what the bug is unless you read the code (or in > my case, ask you), only to find out that "func" is a substring of > "virtual_name". That would have been great in the commit message. >
Sorry :) I was just surprised that nothing/nobody found it before as it's been in for a while, and went to fix it very quickly. > > -- > Tom. > > On 19/07/14 13:00, Daniel Kolesa wrote: > > q66 pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=9f0bcdf70719ceaba94be46095a2854e6ada161d > > > > commit 9f0bcdf70719ceaba94be46095a2854e6ada161d > > Author: q66 <[email protected]> > > Date: Sat Jul 19 13:00:44 2014 +0100 > > > > eolian: ouch... fix a major bug, *spanks self* > > --- > > src/lib/eolian/database_fill.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/src/lib/eolian/database_fill.c > b/src/lib/eolian/database_fill.c > > index af7ea1c..c26271f 100644 > > --- a/src/lib/eolian/database_fill.c > > +++ b/src/lib/eolian/database_fill.c > > @@ -317,12 +317,13 @@ _db_fill_implement(Eolian_Class *cl, > Eolian_Implement *impl) > > ftype = EOLIAN_PROP_GET; > > } > > > > - free(virtual_name); > > - > > Eolian_Function *foo_id = (Eolian_Function*) > > > eolian_class_function_find_by_name(cl, > > > func, > > > ftype); > > + > > + free(virtual_name); > > + > > if (!foo_id) > > { > > ERR("Error - %s not known in class %s", impl_name + 8, > > > > > > > ------------------------------------------------------------------------------ > Want fast and easy access to all the code in your enterprise? Index and > search up to 200,000 lines of code with a free copy of Black Duck > Code Sight - the same software that powers the world's largest code > search on Ohloh, the Black Duck Open Hub! Try it now. > http://p.sf.net/sfu/bds > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
