q66 pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=0c3487cd3d619353b4e296d7b657fceea083fee6
commit 0c3487cd3d619353b4e296d7b657fceea083fee6 Author: Daniel Kolesa <[email protected]> Date: Thu Jul 24 00:32:06 2014 +0100 eolian/generator: fix coverity issues Fixes CID 1228663 and 1228634. --- src/bin/eolian/impl_generator.c | 3 ++- src/bin/eolian/main.c | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/eolian/impl_generator.c b/src/bin/eolian/impl_generator.c index 1043898..2b7aa2b 100644 --- a/src/bin/eolian/impl_generator.c +++ b/src/bin/eolian/impl_generator.c @@ -275,7 +275,8 @@ impl_source_generate(const Eolian_Class *class, Eina_Strbuf *buffer) } eina_iterator_free(itr); - if (eolian_class_implements_get(class)) + itr = eolian_class_implements_get(class); + if (itr) { Eolian_Implement *impl_desc; EINA_ITERATOR_FOREACH(itr, impl_desc) diff --git a/src/bin/eolian/main.c b/src/bin/eolian/main.c index a50f745..c4c4974 100644 --- a/src/bin/eolian/main.c +++ b/src/bin/eolian/main.c @@ -171,10 +171,9 @@ _generate_impl_c_file(char *filename, const Eolian_Class *class) if (eina_strbuf_string_get(buffer)) fputs(eina_strbuf_string_get(buffer), fd); - fclose(fd); - ret = EINA_TRUE; end: + fclose(fd); eina_strbuf_free(buffer); return ret; --
