discomfitor pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6817717ee444a37fe24acb04f6c551e3fed9a688
commit 6817717ee444a37fe24acb04f6c551e3fed9a688 Author: Mike Blumenkrantz <[email protected]> Date: Sun Jul 27 18:51:42 2014 -0400 Revert "eina: Eina_Module - check whether the file exists or not, before memory allocation of Eina_Module" This reverts commit 971589bf56b7b51eba305dfb5e544e6436740534. this completely breaks existing eina_module usage. elm_test->image remote --- src/lib/eina/eina_module.c | 4 +--- src/lib/eina/eina_module.h | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/lib/eina/eina_module.c b/src/lib/eina/eina_module.c index a836d71..2be0a40 100644 --- a/src/lib/eina/eina_module.c +++ b/src/lib/eina/eina_module.c @@ -257,9 +257,7 @@ EAPI Eina_Module *eina_module_new(const char *file) size_t len; EINA_SAFETY_ON_NULL_RETURN_VAL(file, NULL); - - /* check that the file exists. */ - if (access(file, F_OK)) return NULL; + /* TODO check that the file exists. Update doc too */ len = strlen(file); EINA_SAFETY_ON_FALSE_RETURN_VAL(len > 0, NULL); diff --git a/src/lib/eina/eina_module.h b/src/lib/eina/eina_module.h index f6fabdc..f48ca27 100644 --- a/src/lib/eina/eina_module.h +++ b/src/lib/eina/eina_module.h @@ -112,9 +112,9 @@ extern EAPI Eina_Error EINA_ERROR_MODULE_INIT_FAILED; * @brief Return a new module. * * @param file The name of the file module to load. - * @return A new module. If @p file is @c NULL, or if it does not exist, - * the function returns @c NULL, otherwise, it allocates an Eina_Module, - * stores a duplicate string of @p file, sets its reference to @c 0 and + * @return A new module. If @p file is @c NULL, the function + * returns @c NULL, otherwise, it allocates an Eina_Module, stores + * a duplicate string of @p file, sets its reference to @c 0 and * its handle to @c NULL. * * When the new module is not needed anymore, use eina_module_free() --
