Hello.

On Fri, 2014-07-11 at 06:33, Cedric BAIL wrote:
> cedric pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=8062d5d7e9bedaa178072ad795e30b9c217a2371
> 
> commit 8062d5d7e9bedaa178072ad795e30b9c217a2371
> Author: Cedric BAIL <c.b...@partner.samsung.com>
> Date:   Fri Jul 11 12:13:02 2014 +0200
> 
>     eina: make it possible to load module symbol into the global namespace.
> ---

[snip]

> +/**
> + * @brief Define if on module load we should expose all symbol
> + *
> + * @param module The module to turn off/on symbol to be exposed
> + * @since 1.11
> + */
> +EAPI void eina_module_global_set(Eina_Module *module, Eina_Bool global) 
> EINA_ARG_NONNULL(1);

I'm going through the ABI/API reports Tom generated from 1.10 to 1.11
to see what we added, removed, etc.

>From a first look at the funtion I would never thought it was meant to
have the symbols exposed or not. Just looking at the function name I
thought it was more about globally allowing modules or not.

Maybe something like eina_module_symbol_global_set(...) would be
better? Would also be inline with other symbol relevant functions like
_symbol_get and _symbol_path_get

What do you think?

regards
Stefan Schmidt

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to