davemds pushed a commit to branch master.

http://git.enlightenment.org/apps/espionage.git/commit/?id=c8232ff876735cfc3741a4ab145abde9232cfde4

commit c8232ff876735cfc3741a4ab145abde9232cfde4
Author: davemds <[email protected]>
Date:   Sun Aug 10 20:34:21 2014 +0200

    Better error reporting on method execution
---
 espionage/espionage.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/espionage/espionage.py b/espionage/espionage.py
index 54577eb..5c3ea7d 100644
--- a/espionage/espionage.py
+++ b/espionage/espionage.py
@@ -678,8 +678,9 @@ class MethodRunner(StandardWindow):
                 meth(reply_handler=self.reply_handler,
                      error_handler=self.error_handler)
         except Exception as e:
-            s = "Error running method<br>Exception: "
-            self._return_entry.entry = s + utf8_to_markup(str(e))
+            self._return_entry.entry = \
+                    '<b><failure>Error running method</failure><br><br>' \
+                    'Exception:</b><br>%s' % utf8_to_markup(str(e))
 
         # TODO find a way to catch errors after this point
         #      wrong params for example are raised later :/
@@ -688,8 +689,10 @@ class MethodRunner(StandardWindow):
         self._return_entry.entry = prettify_if_needed(rets) if rets \
                 else "Method executed successfully.<br>Nothing returned."
 
-    def error_handler(self, *rets):
-        self._return_entry.entry = 'Error executing method'
+    def error_handler(self, e):
+        self._return_entry.entry = \
+                '<b><failure>Error executing method</failure><br><br>' \
+                'Exception:</b><br>%s' % utf8_to_markup(str(e))
 
 
 ### Signals receiver

-- 


Reply via email to