raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=49694c9a64d99c8974d23e903b5913b3fdfc29fa
commit 49694c9a64d99c8974d23e903b5913b3fdfc29fa Author: Carsten Haitzler (Rasterman) <[email protected]> Date: Thu Aug 14 17:34:39 2014 +0900 xpm - colors cant be 96 bytes long. since colors are hex, 96 bytes of hex would be 32bytes per r, g and b, and that would be 128 bits per r g and b and that just is never seen or used. also coverity is right in CID 1193201 that we just can't shift that many, so go down to max 16 bits per rgb which is sensible and able to be done. (thats 12 bytes max for hex of color). --- src/modules/evas/loaders/xpm/evas_image_load_xpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/evas/loaders/xpm/evas_image_load_xpm.c b/src/modules/evas/loaders/xpm/evas_image_load_xpm.c index 2c8ec96..5617d9f 100644 --- a/src/modules/evas/loaders/xpm/evas_image_load_xpm.c +++ b/src/modules/evas/loaders/xpm/evas_image_load_xpm.c @@ -50,7 +50,7 @@ xpm_parse_color(char *color, int *r, int *g, int *b) int len; len = strlen(color) - 1; - if (len < 96) + if (len < 13) { len /= 3; --
